Fix/text locator heatmap #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopenguin
requested changes
Nov 7, 2024
packages/clients/textLocator/src/plugins/GeometrySearch/utils/vectorDisplay.ts
Outdated
Show resolved
Hide resolved
packages/clients/textLocator/src/plugins/GeometrySearch/utils/vectorDisplay.ts
Outdated
Show resolved
Hide resolved
…vectorDisplay.ts apply suggestion "console debug statement removal" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
…vectorDisplay.ts apply suggestion "console debug statement removal" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
…t/polar into fix/text-locator-heatmap
🏓 @dopenguin The situation has been resolved by providing a changelog entry matching the implementation. 8f54246 |
dopenguin
approved these changes
Nov 8, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| - Breaking: Adapt client to new backend API. Previous versions are no longer runnable due the backend API change. | |||
| - Feature: Implement document search, that is, the AddressSearch bar now also offers results for documents and clicking on one will retrieve a list of toponyms from the backend and resolve them against the gazetteer. Previously, we had a "get all documents regarding place" functionality. Now, a "get all places regarding document" feature is implemented. Additionally to the AddressSearch, this can be triggered on documents found in the previously implemented way; the "get all places regarding document" functionality is available from within the GeoSearch result display. | |||
| - Fix: The heatmap feature has been adjusted to match the new data structure and works again. | |||
There was a problem hiding this comment.
Suggested change
| - Fix: The heatmap feature has been adjusted to match the new data structure and works again. | |
| - Fix: Adjust heatmap feature to match the new data structure and have it working again. |
🎩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instructions for local reproduction and review
Run TextLocator, search for "Health", pick first matching literature result. In the result display, click on the icon for zooming and colouring. The geometry for the river "Eider" should now turn red (since it's the only matching one, and thus matches with max value).
~~The test data is a little boring, I'm requesting additional literature. ~~
Another test: Search for "Runghold" and choose the fictional entry I made up. It's nice for testing and will be used to check the current results in the next fitting weekly.
Relevant tickets, issues, et cetera
Based/Blocks on #172