Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/unknown fitsio cannot open none #1180

Merged
merged 21 commits into from
Aug 1, 2024
Merged

Bug/unknown fitsio cannot open none #1180

merged 21 commits into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. Added stupid way to check for the bug that is presenting in emosaic

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b80a744 View commit details
    Browse the repository at this point in the history

  2. Added projectionNotYetSupported to the sas_errors.csv file - for issue … 

    …#1178
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4f13830 View commit details
    Browse the repository at this point in the history

  3. Removed the print tests

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    797a3f3 View commit details
    Browse the repository at this point in the history

  4. Added more print tests

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b36d1bf View commit details
    Browse the repository at this point in the history

  5. Added more print tests

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    84098af View commit details
    Browse the repository at this point in the history

  6. I don't currently understand a) why this has just started happening, … 

    …and b) how the mosaic function is getting to the stage it is without images existing at all
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    39e7290 View commit details
    Browse the repository at this point in the history

  7. Made sure the ExtendedSource and PointSource classes only try to gene… 

    …rate images on instantiation if they are NOT part of a sample
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bfeaf86 View commit details
    Browse the repository at this point in the history

  8. Added an error to emosaic that will trigger if there are no images, m… 

    …ight help diagnose this. For issue #1178
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7d06ce9 View commit details
    Browse the repository at this point in the history

  9. Fixed the error (was using the wrong source property) that will trigg… 

    …er if there are no images, might help diagnose this. For issue #1178
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    14b86b5 View commit details
    Browse the repository at this point in the history

  10. Trying to pinpoint why this error is happening - issue #1178

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d14a687 View commit details
    Browse the repository at this point in the history

  11. Trying to pinpoint why this error is happening

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7b192c8 View commit details
    Browse the repository at this point in the history

  12. Stopped the error I introduced being thrown for more diagnostics

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c0532f9 View commit details
    Browse the repository at this point in the history

  13. Stopped the error I introduced being thrown for more diagnostics

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9ae70ac View commit details
    Browse the repository at this point in the history

  14. SO MANY DEBUGGING BITS ADDED

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c186a1e View commit details
    Browse the repository at this point in the history

  15. I think the issue is that instruments with no event lists are being k… 

    …ept in the products return from _initial_products? I have absolutely no idea why this has never reared its head before, and I'm still working to confirm. For issue #1178
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3151ea3 View commit details
    Browse the repository at this point in the history

  16. Nope, it is at some point hallucinating that 0105262401 has PN associ… 

    …ated, because that is not how the original _products structure goes. For issue #1178
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b373508 View commit details
    Browse the repository at this point in the history

  17. a

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    893fa1b View commit details
    Browse the repository at this point in the history

  18. Bad commit message

    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    21b38ab View commit details
    Browse the repository at this point in the history

  19. The self._instruments attribute was not necessarily being set properl… 

    …y - I now use the _products information returned by _initial_products to cut any instruments that didn't have an event list. For issue #1178
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ac6228f View commit details
    Browse the repository at this point in the history

  20. I may have fixed issue #1178, removing all the stupid debugging bits … 

    …I put in.
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    882966e View commit details
    Browse the repository at this point in the history

  21. Forgot a print statement - for issue #1178 (think this is the problem… 

    … sorted now)
    @DavidT3
    DavidT3 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0b49e17 View commit details
    Browse the repository at this point in the history