[Mellanox] Add support for SN4600 system #2

DavidZagury · 2021-02-14T17:33:57Z

Why I did it

Support new Mellanox system SN4600

How I did it

Add relevant files to support new platform names platform x86_64-mlnx_msn4600 and default SKU ACS-MSN4600

How to verify it

Load the SN4600 switch, verify all ports are up with 200G by default.

Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

liat-grozovik · 2021-02-15T14:08:03Z

Suggest to change the PR title to something shorted such as "[Mellanox] Add support for SN4600 system"

liat-grozovik · 2021-02-15T14:10:26Z

Suggest to rephrase the comment to something like
"

Why I did it
Support new Mellanox system SN4600
How I did it
Add relevant files to support new platform names platform x86_64-mlnx_msn4600 and default SKU ACS-MSN4600
How to verify it
Load the SN4600 switch, verify all ports are up with 200G by default.

"

Note: this is needed for 202012 as well. so please mark it.

liat-grozovik · 2021-02-15T14:11:33Z

device/mellanox/x86_64-mlnx_msn2700-r0/plugins/sfputil.py

+platform_dict = {'x86_64-mlnx_msn2700-r0': 0, 'x86_64-mlnx_msn2740-r0': 0, 'x86_64-mlnx_msn2100-r0': 1,
+                 'x86_64-mlnx_msn2410-r0': 2, 'x86_64-mlnx_msn2010-r0': 3, 'x86_64-mlnx_msn3420-r0': 5,
+                 'x86_64-mlnx_msn3700-r0': 0, 'x86_64-mlnx_msn3700c-r0': 0, 'x86_64-mlnx_msn3800-r0': 4,
+                 'x86_64-mlnx_msn4600': 4, 'x86_64-mlnx_msn4600c': 4, 'x86_64-mlnx_msn4700-r0': 0}


why adding it in the middle and not in as the last one?

why all has -r0 and only SN4600 and SN4600C does not?

Fix for 4600, and talked with @shlomibitton and he will fix 4600C

device/mellanox/x86_64-mlnx_msn4600-r0/ACS-MSN4600/hwsku.json

device/mellanox/x86_64-mlnx_msn4600-r0/ACS-MSN4600/buffers_dynamic.json.j2

device/mellanox/x86_64-mlnx_msn4600-r0/ACS-MSN4600/port_config.ini

liat-grozovik · 2021-02-15T14:17:45Z

device/mellanox/x86_64-mlnx_msn4600-r0/ACS-MSN4600/sai_4600.xml

@@ -0,0 +1,471 @@
+<?xml version="1.0"?>


please send the file to Itai to confirm it. Not sure if he has one to use on SAI github but at least he need to confirm it

We talked with Itay which told us that the file is already in github which I found here:
https://github.com/Mellanox/SAI-Implementation/blob/80937117fcd54e8df0581368f652f3664af6aecb/mlnx_sai/src/sai_4600.xml

But he did say it was a draft file.

device/mellanox/x86_64-mlnx_msn4600-r0/sensors.conf

liat-grozovik · 2021-02-15T14:21:46Z

platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py

+platform_dict_port = {'x86_64-mlnx_msn2010-r0': 3, 'x86_64-mlnx_msn2100-r0': 1, 'x86_64-mlnx_msn2410-r0': 2,
+                      'x86_64-mlnx_msn2700-r0': 0, 'x86_64-mlnx_lssn2700': 0, 'x86_64-mlnx_msn2740-r0': 0,
+                      'x86_64-mlnx_msn3420-r0': 5, 'x86_64-mlnx_msn3700-r0': 0, 'x86_64-mlnx_msn3700c-r0': 0,
+                      'x86_64-mlnx_msn3800-r0': 4, 'x86_64-mlnx_msn4600-r0': 4, 'x86_64-mlnx_msn4600c-r0': 4,


why adding in the middle and not on the last?

The list was already ordered by the switch number and I wanted to keep this order

liat-grozovik · 2021-02-15T14:23:02Z

platform/mellanox/mlnx-platform-api/sonic_platform/device_data.py

+    'x86_64-mlnx_msn4600-r0': {
+        'thermal': {
+            'minimum_table': {
+                "unk_trust": {"-127:40": 12, "41:120": 13},


for these numbers please review with Vadim P
we can only approve them after platform test is fully running on this system.

I talked with Vadim, he didn't have time for doing a full review but told me to check that it the same as the Leopard, I checked and they are only different on the fans and unk, for those change he said that fans are correct, and unk should be the same as Tigon which it is.

liat-grozovik · 2021-02-15T14:23:43Z

platform/mellanox/mlnx-platform-api/sonic_platform/thermal.py

 thermal_profile_list = [
-    # 2700
+    # 0 2700


what is do you need a leading number in the comment?

The platform_dict_thermal is supposed to have the index of the switch thermal_profile_list, I added those to help me find the index of my switch in the array.

I kept it because it having this information in front of our eyes helped me realize there is a mistake in other switches (x86_64-mlnx_msn3420-r0 having 9 as its index when in fact it is in the 11th place of the array, 4410 which is in the 11 place of the list is missing from this array at all).

I can remove it if it is not needed

device/mellanox/x86_64-mlnx_msn4600-r0/pcie.yaml

platform/mellanox/mlnx-platform-api/sonic_platform/device_data.py

shlomibitton

As commented

Upgrade DellEMC platforms to bullseye.

#### Why I did it Update sonic-host-services submodule to include below commits: ``` bc8698d Merge pull request #21 from abdosi/feature 557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception. 6e45acc (master) Merge pull request #14 from abdosi/feature 4d6cad7 Merge remote-tracking branch 'upstream/master' into feature bceb13e Install libyang to azure pipeline (#20) 82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns 15d3bf4 Merge branch 'master' into cacl_fabricns de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log b4b368d Add warning log if destination port is not defined d4bb96d Merge branch 'master' into cacl_fabricns 35c76cb Add unit-test and fix typo. 17d44c2 Made Changes to be Python 3.7 compatible 978afb5 Aligning Code 1fbf8fb Merge remote-tracking branch 'upstream/master' into feature 7b8c7d1 Added UT for the changes 91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client 7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6 b71e507 Merge remote-tracking branch 'origin/master' into HEAD d992dc0 Merge branch 'master' into feature/caclmgrd_external_client bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2) 70ce6a3 Merge pull request #10 from sujinmkang/cold_reset 29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table. 3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces. 8720561 Fix and add hardware reboot cause determination tests 0dcc7fe remove the empty bracket if no hardware reboot cause minor e47d831 fix the wrong expected result comparision ef86b53 Fix startswith Attribute error 8a630bb fix mock patch 8543ddf update the reboot cause logic and update the unit test 53ad7cd fix the mock patch function 7c8003d fix the reboot-cause regix for test 1ba611f fix typo 25379d3 Add unit test case a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed c7d3833 Support Restapi/gnmi control plane acls f6ea036 caclmgrd: Don't block traffic to mgmt by default a712fc4 Update test cases adc058b caclmgrd: Don't block traffic to mgmt by default 06ff918 Merge pull request #7 from bluecmd/patch-1 e3e23bc ci: Rename sonic-buildimage repository e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test f5a2e50 [caclmgrd]: Tests for IP2ME rules generation ```

To fix a statistical issue. The original fix was done in FRRouting/frr#17297. However to accommodate 8.5.4 the patch in the PR was added. [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'. Program terminated with signal SIGABRT, Aborted. #0 0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6 [Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))] (gdb) bt #0 0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6 #3 0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678 #4 0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352 #5 0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258 #6 route_next (node=<optimized out>) at ../lib/table.c:436 #7 route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410 #8 0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020") at ../zebra/interface.c:312 #9 0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867 #10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221 #11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810 #12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990 #13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198 #14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478

DavidZagury force-pushed the sku-msn4600 branch from be0b338 to cc6ce46 Compare February 14, 2021 17:41

liat-grozovik suggested changes Feb 15, 2021

View reviewed changes

DavidZagury force-pushed the sku-msn4600 branch from cc6ce46 to 1d8959f Compare February 15, 2021 15:05

DavidZagury force-pushed the master branch from 852f6de to f6bee73 Compare February 15, 2021 15:29

DavidZagury force-pushed the sku-msn4600 branch from 1d8959f to a11d7da Compare February 15, 2021 16:58

DavidZagury changed the title ~~[Mellanox] Add a new Mellanox platform x86_64-mlnx_msn4600 and new SKU ACS-MSN4600~~ [Mellanox] Add support for SN4600 system Feb 15, 2021

DavidZagury force-pushed the sku-msn4600 branch from a11d7da to 64bff11 Compare February 16, 2021 10:30

shlomibitton reviewed Feb 18, 2021

View reviewed changes

device/mellanox/x86_64-mlnx_msn4600-r0/pcie.yaml Show resolved Hide resolved

shlomibitton reviewed Feb 18, 2021

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/device_data.py Outdated Show resolved Hide resolved

shlomibitton reviewed Feb 18, 2021

View reviewed changes

DavidZagury force-pushed the sku-msn4600 branch from 64bff11 to a983396 Compare February 18, 2021 11:51

shlomibitton approved these changes Feb 22, 2021

View reviewed changes

DavidZagury force-pushed the sku-msn4600 branch from a983396 to 827ed95 Compare February 24, 2021 09:07

[Mellanox] Add support for SN4600 system

86f5697

DavidZagury force-pushed the sku-msn4600 branch from 827ed95 to 86f5697 Compare February 24, 2021 13:48

DavidZagury closed this Mar 14, 2021

DavidZagury deleted the sku-msn4600 branch March 25, 2021 15:17

DavidZagury pushed a commit that referenced this pull request Dec 8, 2021

DellEMC bullseye merge (#2)

c3c6a17

Upgrade DellEMC platforms to bullseye.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox] Add support for SN4600 system #2

[Mellanox] Add support for SN4600 system #2

DavidZagury commented Feb 14, 2021 •

edited

Loading

liat-grozovik commented Feb 15, 2021

liat-grozovik commented Feb 15, 2021 •

edited

Loading

liat-grozovik Feb 15, 2021

liat-grozovik Feb 15, 2021

DavidZagury Feb 16, 2021

liat-grozovik Feb 15, 2021

DavidZagury Feb 15, 2021

liat-grozovik Feb 15, 2021

DavidZagury Feb 15, 2021

liat-grozovik Feb 15, 2021

DavidZagury Feb 16, 2021

liat-grozovik Feb 15, 2021

DavidZagury Feb 15, 2021

shlomibitton left a comment

[Mellanox] Add support for SN4600 system #2

[Mellanox] Add support for SN4600 system #2

Conversation

DavidZagury commented Feb 14, 2021 • edited Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

liat-grozovik commented Feb 15, 2021

liat-grozovik commented Feb 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shlomibitton left a comment

Choose a reason for hiding this comment

DavidZagury commented Feb 14, 2021 •

edited

Loading

liat-grozovik commented Feb 15, 2021 •

edited

Loading