[Mellanox] Use efibootmgr for supported device on fwutil #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add the force flag to the reboot, which is needed now that we no longer use power cycle due to sonic-net#18325
nazariig
reviewed
Jun 25, 2024
nazariig
reviewed
Jun 26, 2024
| @@ -106,7 +115,7 @@ system_reboot() { | |||
| sleep 5s | |||
|
|
|||
| # Use SONiC reboot scenario | |||
| /usr/local/bin/reboot | |||
| /usr/local/bin/reboot -f | |||
There was a problem hiding this comment.
@DavidZagury why do we need force here? Did u try without force?
There was a problem hiding this comment.
@nazariig Yes, I tried without the force, this is what solved the issue we discussed.
nazariig
approved these changes
Jul 3, 2024
nazariig
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add the force flag to the reboot, which is needed now that we no longer use power cycle due to # 18325
Why I did it
Work item tracking
How I did it
Update the onie fw update script to use efibootmgr for the supported devices, and on the reboot command, call the reboot script with the f flag.
How to verify it
Run ONIE upgrade using fwutil
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)