Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Adding SKU Mellanox-SN5600-C256 #58

Closed
wants to merge 10 commits into from

Conversation

DavidZagury
Copy link
Owner

@DavidZagury DavidZagury commented Jul 15, 2024

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dprital
Copy link
Collaborator

dprital commented Jul 15, 2024

@DavidZagury , Since CMIS Host Management should be enabled on this SKU, you need to add the following files as well:

  • optict_si_settings.json
  • media_settings.json

@DavidZagury
Copy link
Owner Author

@DavidZagury , Since CMIS Host Management should be enabled on this SKU, you need to add the following files as well:

  • optict_si_settings.json
  • media_settings.json

@dprital Resolved

@DavidZagury DavidZagury requested a review from stephenxs July 17, 2024 12:02
{% set default_cable = '40m' %}
{% set ingress_lossless_pool_size = '104773632' %}
{% set ingress_lossless_pool_xoff = '26165248' %}
{% set egress_lossless_pool_size = '162027520' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this value is too large to be accepted by SDK. Let's use 158229504

{% set default_cable = '300m' %}
{% set ingress_lossless_pool_size = '124303360' %}
{% set ingress_lossless_pool_xoff = '20529152' %}
{% set egress_lossless_pool_size = '162027520' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 158229504

@DavidZagury DavidZagury closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants