Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 more parameters about the volumes #63

Closed
DavideViolante opened this issue Aug 17, 2022 · 1 comment · Fixed by #142
Closed

Add 2 more parameters about the volumes #63

DavideViolante opened this issue Aug 17, 2022 · 1 comment · Fixed by #142
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@DavideViolante
Copy link
Owner

DavideViolante commented Aug 17, 2022 •
edited
Loading

item[5] and item[6] probably (help wanted) represents the volume, add them into the APIs.

Eg for dow jones:

        [
            1645660800000,
            32830.33,
            33269.34,
            32272.64,
            33223.83,
            593186432, // volume?
            0 // volume?
        ],
@DavideViolante DavideViolante added the enhancement New feature or request label Aug 17, 2022
@DavideViolante DavideViolante added the help wanted Extra attention is needed label Sep 23, 2022
liardoecp added a commit to liardoecp/investing-com-api that referenced this issue Oct 20, 2024
@liardoecp
Add volume in mapResponse
8ee6a43 
Fixes DavideViolante#63
@liardoecp liardoecp mentioned this issue Oct 20, 2024
Merged
@liardoecp
Copy link
Contributor 

        [
            1645660800000,
            32830.33,
            33269.34,
            32272.64,
            33223.83,
            593186432, // volume
            0 // I have not found any examples with non-zero values, so I don't know what means this value. Maybe it's not used anymore
        ],

liardoecp added a commit to liardoecp/investing-com-api that referenced this issue Oct 21, 2024
@liardoecp
add value in mapResponse (DavideViolante#63)
3d3acdd
liardoecp added a commit to liardoecp/investing-com-api that referenced this issue Oct 21, 2024
@liardoecp
fix mapResponse() test (DavideViolante#63)
4996eb1
liardoecp added a commit to liardoecp/investing-com-api that referenced this issue Oct 21, 2024
@liardoecp
fix linting (DavideViolante#63)
9a24ace
DavideViolante pushed a commit that referenced this issue Oct 22, 2024
@liardoecp
feat: add volume to response (#142)
678b742 
* Add volume in mapResponse
Fixes #63

* add value in mapResponse (#63)

* fix mapResponse() test (#63)

* fix linting (#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add volume to response liardoecp/investing-com-api
2 participants
@DavideViolante @liardoecp