Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation to describe the quirk regarding schemaversions #8

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Jeern
Copy link
Collaborator

@Jeern Jeern commented Jul 31, 2024

Checklist

  • I have read the Contributing Guide
  • I have checked to ensure this does not introduce an unintended breaking changes
  • I have considered appropriate testing for my change

Description

Documentation to mitigate the problem with the name of the journal table describe in #5

@Jeern Jeern requested a review from droyad July 31, 2024 14:54
Copy link
Member

@droyad droyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also thinking we should start add provider specific doco to the public docs (https://github.com/DbUp/DbUp/tree/main/docs)

@Jeern
Copy link
Collaborator Author

Jeern commented Aug 1, 2024

@droyad Thanks for approving. It seems I cannot merge - it says "The base branch restricts merging to authorized users."

@Jeern Jeern linked an issue Aug 1, 2024 that may be closed by this pull request
1 task
@droyad
Copy link
Member

droyad commented Aug 1, 2024

Hmmm.. maybe because all the build checks haven't passed. Since the build name on v6 is different we can't make them match. This should resolve itself when we merge v6 to main. In the meantime I'm happy to do the merge.

@droyad droyad merged commit 867c8a1 into main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name of SchemaVersions table
2 participants