Rebase to master, and enable path agnostic rust builds (#1895)

* Fix typo in clang dockerfile (#1842)

* Update PULL_REQUEST_TEMPLATE.md

* mingw fixes for bcrypt, suppress depends related warnings  (#1847)

* Suppress depends related superfluous warnings

* Fix passthrough string quote

* Fix windres, bcrypt failures

* Cleanup build process and workflows (#1851)

* Suppress depends related superfluous warnings

* Fix passthrough string quote

* Fix windres, bcrypt failures

* Cleanup build, workflows, dockerfiles

* Cleanup comments

* Refactor default var setup

* Cleanup comments

* Add safe_rm_rf and simplify left file list

* Fix shellcheck

* Fix arm core images

* More cleanup, unify packaging, safer rm

* Apply default conf across all arch, conf args append

* Apply glibc compat only on linux builds

* Clean up obsolete comments

* Cleanup unmaintained deps, configs and tools (#1855)

* Suppress depends related superfluous warnings

* Fix passthrough string quote

* Fix windres, bcrypt failures

* Cleanup build, workflows, dockerfiles

* Cleanup comments

* Refactor default var setup

* Cleanup comments

* Add safe_rm_rf and simplify left file list

* Fix shellcheck

* Fix arm core images

* More cleanup, unify packaging, safer rm

* Apply default conf across all arch, conf args append

* Apply glibc compat only on linux builds

* Clean up obsolete comments

* Cleanup unmaintained files

* Remove install.md

* Remove libdeficonsensus dyn lib, defi-wallet

* Enable static linking

* Revert boost changes

* Remove outdated man pages

* Remove debian packaging related file

* Bump boost min to 1.77, remove obsolete checks

* Revert boost config cleanup

* More cleanups, nsis, gitian

* Remove boost reduce exports change

* Cleanup boost obsolete check

* Remove wallet tool test

* Update toolchains, deps and further cleanup (#1857)

* Suppress depends related superfluous warnings

* Fix passthrough string quote

* Fix windres, bcrypt failures

* Cleanup build, workflows, dockerfiles

* Cleanup comments

* Refactor default var setup

* Cleanup comments

* Add safe_rm_rf and simplify left file list

* Fix shellcheck

* Fix arm core images

* More cleanup, unify packaging, safer rm

* Apply default conf across all arch, conf args append

* Apply glibc compat only on linux builds

* Clean up obsolete comments

* Cleanup unmaintained files

* Remove install.md

* Remove libdeficonsensus dyn lib, defi-wallet

* Enable static linking

* Revert boost changes

* Remove outdated man pages

* Remove debian packaging related file

* Bump boost min to 1.77, remove obsolete checks

* Revert boost config cleanup

* More cleanups, nsis, gitian

* Remove boost reduce exports change

* Cleanup boost obsolete check

* Reorganize scripts, merge share and contrib

* Fix docker script

* Remove wallet tool test

* static libgcc, disable tests and benches on CI builds

* Fix CI builds to use consistent compilers

* Better consistency in toolchains

* Remove cdrkit, libdmg and switch to docker multiplatform base

* Update cppcheck version

* Switch libdeficonsensus to internal, toolchain cleanups  (#1860)

* Cleanup deps

* Switch libdeficonsensus to an internal lib

* Update ubuntu bases

* Update darwin llvm to 16, update cctools and all depends (#1862)

* Update toolchains

* Remove obsolete zeromq patches

* Make libtapi path agnostic of version

* Update XCode SDK

* Rename target to x86_64-apple-darwin

* Revert to older behavior of zeromq

* Remove superfluous LIBADD

* Couple LDFLAGS together

* Skip unrecognized flag on clang

* Fix unintended quote

* Overhaul of build, CI tests and lints, packaging and deps (#1880)

* Fix spv out of tree builds

* Sync dockerignore and gitignore

* Overhaul of builds (to out of tree), deps updates, simplify dockefiles, CI test, lints and more

* Uncomment benchmark code, disable with flags instead

* Resolve compiler warnings

* Fix arm64 crc intrinsics flags

* Minor CI updates and docker login fixes

* Add `--prefix` into configure to workaround surviving config.sub rechecks

* Update ignores (#1888)

* Fixes for make.sh undeclared locals and clean-artifacts (#1887)

* Fix local decls in make.sh

* Fix lints

* Actually fix lints

* Minimal change set to enable rust build

* fmt

* Include google protos to remove external dependence

* Cleanup unused vars

---------

Co-authored-by: Shoham Chakraborty <shhmchk@gmail.com>

.dockerignore

@@ -1,60 +1,70 @@
-# depends
-
-depends/built
-depends/work
-depends/sources
-depends/x86_64*
-depends/i686*
-depends/mips*
-depends/arm*
-depends/aarch64*
-depends/riscv32*
-depends/riscv64*
-
-## Copy of .gitignore
-
 .code
 .idea
-build
 
+# Editors.
+*.sw*
+.vscode
+.clangd
+
+# Misc
 *.tar.gz
+*.tmp
 
+# Build
+build/
+out/
 *.exe
 *.pdb
+
+# Univalue 
+
 src/defi
 src/defid
 src/defi-cli
 src/defi-tx
 src/defi-wallet
 src/test/test_defi
 src/test/test_defi_fuzzy
+src/config/defi-config.h
+src/config/defi-config.h.in
+src/obj
+src/univalue/gen
+src/secp256k1/gen_context
+src/secp256k1/src/ecmult_static_context.h
 
-# autoreconf
+# autotools
+
+Makefile
 Makefile.in
-aclocal.m4
-autom4te.cache/
-build-aux/config.guess
-build-aux/config.sub
-build-aux/depcomp
-build-aux/install-sh
-build-aux/ltmain.sh
-build-aux/m4/libtool.m4
-build-aux/m4/lt~obsolete.m4
-build-aux/m4/ltoptions.m4
-build-aux/m4/ltsugar.m4
-build-aux/m4/ltversion.m4
-build-aux/missing
-build-aux/compile
-build-aux/test-driver
+Makefile.am.user
+Makefile.test
+!depends/Makefile
+!src/leveldb*/Makefile
+
 config.log
 config.status
 configure
+configure~
+
+aclocal.m4
+autom4te.cache/
+**/build-aux/config.guess
+**/build-aux/config.sub
+**/build-aux/depcomp
+**/build-aux/install-sh
+**/build-aux/ltmain.sh
+**/build-aux/m4/ar-lib.m4
+**/build-aux/m4/libtool.m4
+**/build-aux/m4/lt~obsolete.m4
+**/build-aux/m4/ltoptions.m4
+**/build-aux/m4/ltsugar.m4
+**/build-aux/m4/ltversion.m4
+**/build-aux/missing
+**/build-aux/compile
+**/build-aux/test-driver
+
 libtool
-src/config/defi-config.h
-src/config/defi-config.h.in
-src/config/stamp-h1
-src/obj
-share/setup.nsi
+stamp-h1
 
 .deps
 .dirstamp
@@ -82,27 +92,15 @@ share/setup.nsi
 # Only ignore unexpected patches
 *.patch
 !depends/patches/**/*.patch
+!contrib/devtools/*.patch
 
 #libtool object files
 *.lo
 *.la
 
-# Compilation
+# Compilation and Qt preprocessor part
 *.qm
-Makefile
-!depends/Makefile
 background.tiff*
-Makefile.am.user
-
-# Unit-tests
-Makefile.test
-
-# Resources cpp
-qrc_*.cpp
-
-# Mac specific
-.DS_Store
-build
 
 #lcov
 *.gcno
@@ -119,22 +117,31 @@ win32-build
 test/config.ini
 test/cache/*
 
-!src/leveldb*/Makefile
-
-/doc/doxygen/
-
-libdeficonsensus.pc
-contrib/devtools/split-debug.sh
-
 # Output from running db4 installation
 db4/
 
-# clang-check
+# Mac
+.DS_Store
 *.plist
-
 osx_volname
 dist/
 *.background.tiff
 
-# spv
-!src/spv/Makefile
+# VSCode extension LocalHistory
+.history
+
+# compile_commands.json
+compile_commands.json
+
+# Others
+
+/doc/doxygen/
+contrib/devtools/split-debug.sh
+
+# CI scratch area used for tests
+/ci/scratch/
+
+# Potential rust paths to keep things clean
+# as we switch between branches
+/src/rust/target
+/lib/target

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,11 +2,11 @@
 Thanks for sending a pull request!
 
 - Check out our contributing guidelines, https://github.com/DeFiCh/ain/blob/master/CONTRIBUTING.md
-- Pull requests without a rationale and clear improvement may be closed. 
 - Even small changes will need to have multiple eyes and require substantial time effort to review.
 - Please use bullet points to summarize as well as provide detailed info as much as possible.
 - Short bullet points are easier to read and process.
-- If you'd like to add detailed notes, split the summary with a "Details" section. 
+- If you'd like to add detailed notes, split the summary with a "Details" section.
+- Delete sections that are empty except for implications. 
 -->
 
 ## Summary
@@ -15,29 +15,35 @@ Thanks for sending a pull request!
 
 ## RPCs
 
+<!-- Please remove section if deemed to be empty -->
 - 
 
 ## Flags
 
+<!-- Please remove section if deemed to be empty -->
 - 
 
 ## Protocol
 
+<!-- Please remove section if deemed to be empty -->
 - 
 
 ## Storage
 
+<!-- Please remove section if deemed to be empty -->
 - 
 
 ## Implications
 
-- Index changes
-  - [ ] Reindex required
-  - [ ] Reindex optional
-  - [ ] Reindex not required
+- Storage
+  - [ ] Database reindex required
+  - [ ] Database reindex optional
+  - [ ] Database reindex not required
+  - [ ] None
 
 - Consensus
   - [ ] Network upgrade required
   - [ ] Includes backward compatible changes
   - [ ] Includes consensus workarounds
-  - [ ] Includes consensus refactors
+  - [ ] Includes consensus refactors
+  - [ ] None