Add CustomTxType FromString method #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouzo
requested review from
uzyn,
Bushstar,
bvbfan,
Mixa84 and
surangap
as code owners
Jouzo
force-pushed
the
feature/customtxtype_fromstring
branch
from
30b4d46
to
773a205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
listaccounthistorynow acceptstxtypekey as custom tx name and custom tx code.This smoothens the use of
listaccounthistoryas previously one had to lookup the correct txcode to filter history bytxtype.Both these usages are correct and give the same result :
Which issue(s) does this PR fixes?:
Fixes #1176