-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on-chain goverment voting scenarios test #1727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcorral
approved these changes
Feb 2, 2023
Bushstar
approved these changes
Feb 2, 2023
shohamc1
added a commit
that referenced
this pull request
Feb 3, 2023
commit 32c9295 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Fri Feb 3 13:11:51 2023 +0800 Update test commit 15fb0e5 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Fri Feb 3 12:38:41 2023 +0800 Use VotingInfo, remove unknown votes from output commit 0609603 Merge: e51834a faaad56 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 22:42:22 2023 +0800 Merge branch 'master' into proposalvotes-stats commit faaad56 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 20:09:41 2023 +0800 Fix setgov crashes (#1719) Co-authored-by: Prasanna Loganathar <pvl@prasannavl.com> commit 7807454 Author: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com> Date: Thu Feb 2 11:13:43 2023 +0100 Fix voting scenarios test (#1727) commit e51834a Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 15:38:06 2023 +0800 Fix test commit 808ed6e Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:49:20 2023 +0800 Redo neutral changes commit 4a9c8f0 Merge: bc55ada b7b14c2 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:30:31 2023 +0800 Merge branch 'master' into proposalvotes-stats # Conflicts: # src/masternodes/rpc_proposals.cpp # test/functional/feature_on_chain_government.py commit bc55ada Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:27:51 2023 +0800 Refactor tests commit e47befd Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:25:13 2023 +0800 Default cycles fix commit 44d0a02 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 15:08:29 2023 +0800 Fix isMine default commit 7246e04 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 14:51:04 2023 +0800 Fix multiple proposal output when aggregating commit 8b072df Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 14:45:48 2023 +0800 Fix output schema commit 9fa408b Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Mon Jan 30 12:09:57 2023 +0800 Add aggregate stats support to listgovproposalvotes
Bushstar
added a commit
that referenced
this pull request
Feb 7, 2023
…1725) * Squashed commit of the following: commit e51834a Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 15:38:06 2023 +0800 Fix test commit 808ed6e Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:49:20 2023 +0800 Redo neutral changes commit 4a9c8f0 Merge: bc55ada b7b14c2 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:30:31 2023 +0800 Merge branch 'master' into proposalvotes-stats # Conflicts: # src/masternodes/rpc_proposals.cpp # test/functional/feature_on_chain_government.py commit bc55ada Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:27:51 2023 +0800 Refactor tests commit e47befd Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:25:13 2023 +0800 Default cycles fix commit 44d0a02 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 15:08:29 2023 +0800 Fix isMine default commit 7246e04 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 14:51:04 2023 +0800 Fix multiple proposal output when aggregating commit 8b072df Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 14:45:48 2023 +0800 Fix output schema commit 9fa408b Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Mon Jan 30 12:09:57 2023 +0800 Add aggregate stats support to listgovproposalvotes * Add vote validity and filter * Squashed commit of the following: commit 32c9295 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Fri Feb 3 13:11:51 2023 +0800 Update test commit 15fb0e5 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Fri Feb 3 12:38:41 2023 +0800 Use VotingInfo, remove unknown votes from output commit 0609603 Merge: e51834a faaad56 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 22:42:22 2023 +0800 Merge branch 'master' into proposalvotes-stats commit faaad56 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 20:09:41 2023 +0800 Fix setgov crashes (#1719) Co-authored-by: Prasanna Loganathar <pvl@prasannavl.com> commit 7807454 Author: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com> Date: Thu Feb 2 11:13:43 2023 +0100 Fix voting scenarios test (#1727) commit e51834a Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 15:38:06 2023 +0800 Fix test commit 808ed6e Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:49:20 2023 +0800 Redo neutral changes commit 4a9c8f0 Merge: bc55ada b7b14c2 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:30:31 2023 +0800 Merge branch 'master' into proposalvotes-stats # Conflicts: # src/masternodes/rpc_proposals.cpp # test/functional/feature_on_chain_government.py commit bc55ada Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:27:51 2023 +0800 Refactor tests commit e47befd Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Thu Feb 2 14:25:13 2023 +0800 Default cycles fix commit 44d0a02 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 15:08:29 2023 +0800 Fix isMine default commit 7246e04 Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 14:51:04 2023 +0800 Fix multiple proposal output when aggregating commit 8b072df Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Wed Feb 1 14:45:48 2023 +0800 Fix output schema commit 9fa408b Author: Shoham Chakraborty <shhmchk@gmail.com> Date: Mon Jan 30 12:09:57 2023 +0800 Add aggregate stats support to listgovproposalvotes * Remove test file --------- Co-authored-by: Peter John Bushnell <bushsolo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind chore
What this PR does / why we need it:
Fix failing test.