Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Require to simple if branches on payback hotpaths #1769

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

DocteurPing
Copy link
Contributor

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

Put back the if statement instead of Require in order to improve the performances

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@prasannavl prasannavl changed the title Revert Require to if Revert Require to if on payback hotpaths Feb 20, 2023
@prasannavl prasannavl changed the title Revert Require to if on payback hotpaths Revert Require to simple if branches on payback hotpaths Feb 20, 2023
@prasannavl prasannavl merged commit aebeeb6 into master Feb 20, 2023
@prasannavl prasannavl deleted the require_to_if branch February 20, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants