Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: getburninfo performance improvements #1788

Merged
merged 18 commits into from
Mar 3, 2023
Merged

rpc: getburninfo performance improvements #1788

merged 18 commits into from
Mar 3, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Mar 1, 2023 •
edited
Loading

/kind fix

  • Use a fixed buffer that's handed out to each worker to prevent reallocation of large vector space
  • Memoize getburninfo results to make it only scan from the previous scan height

@prasannavl prasannavl changed the title Fixed buffers to prevent large allocations on getburninfo WIP: Fixed buffers to prevent large allocations on getburninfo Mar 1, 2023
@prasannavl prasannavl changed the title WIP: Fixed buffers to prevent large allocations on getburninfo rpc: getburninfo performance improvements Mar 3, 2023
prasannavl
prasannavl commented Mar 3, 2023
View reviewed changes
src/rpc/resultcache.cpp Outdated Show resolved Hide resolved
prasannavl
prasannavl commented Mar 3, 2023
View reviewed changes
src/rpc/resultcache.h Outdated Show resolved Hide resolved
prasannavl
prasannavl commented Mar 3, 2023
View reviewed changes
src/rpc/resultcache.h Outdated Show resolved Hide resolved
prasannavl
prasannavl commented Mar 3, 2023
View reviewed changes
src/rpc/resultcache.h Outdated Show resolved Hide resolved
prasannavl
prasannavl commented Mar 3, 2023
View reviewed changes
Copy link
Member Author

@prasannavl prasannavl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impl looks great. Let's make the changes to improve maintainability and merge.

@prasannavl prasannavl merged commit 0f29d5d into master Mar 3, 2023
@prasannavl prasannavl deleted the pvl/par-burninfo-improvements branch March 3, 2023 01:47
This was referenced Mar 3, 2023
Merged
Merged
@prasannavl prasannavl restored the pvl/par-burninfo-improvements branch March 3, 2023 15:02
@prasannavl prasannavl deleted the pvl/par-burninfo-improvements branch April 10, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prasannavl prasannavl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasannavl @defichain-bot @Mixa84 @Jouzo