Fix CLockFreeGuard, introduce AtomicMutex #1797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind fix
CLockFreeGuard
uses barrier that's unsuitable for general use case, and results in multiple threads entering critical sections due to premature barrier optimizations. This fixes it.AtomicMutex
that progressively spins, yields and sleeps to remove this, while also working with regularunique_lock
patterns.CLockFreeGuard
entirely in subsequent PRs and replace it with standard patterns ofstd::unique_lock
coupled withAtomicMutex