Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: eth_getLogs #2062

Merged
merged 13 commits into from
Jun 14, 2023
Merged

evm: eth_getLogs #2062

merged 13 commits into from
Jun 14, 2023

Conversation

shohamc1
Copy link
Contributor

@shohamc1 shohamc1 commented Jun 14, 2023 •
edited
Loading

Summary

  • Implement eth_getLogs RPC
  • Same backend can be reused for filter RPCs (eth_getFilterChanges/eth_getFilterLogs)

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@shohamc1 shohamc1 self-assigned this Jun 14, 2023
@shohamc1 shohamc1 requested a review from Jouzo June 14, 2023 08:03
@shohamc1 shohamc1 marked this pull request as ready for review June 14, 2023 08:29
@Jouzo Jouzo merged commit d34e189 into master Jun 14, 2023
@Jouzo Jouzo deleted the evm/get-logs branch June 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

Assignees

@shohamc1 shohamc1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shohamc1 @Jouzo