Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix test sync workflow #2091

Merged
merged 18 commits into from
Jun 21, 2023
Merged

CI: Fix test sync workflow #2091

merged 18 commits into from
Jun 21, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Jun 19, 2023

Summary

  • Fixes to the currently failing test-sync CI
  • Refactor main.sh with shell scripting standards
  • Refactor the sync pipeline with start_node_wait function that starts the defid node process and stores the PID.
  • Refactor the sync pipeline with stop_node function that stops the defid node process, and tracks the state of the defid process to ensure node transits to exit.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven self-assigned this Jun 19, 2023
@sieniven sieniven mentioned this pull request Jun 19, 2023
9 tasks
@sieniven
Copy link
Member Author

sieniven commented Jun 19, 2023

The PR fixes the CI workflow, but fails on diff log check with the reference logs stored on the gc.
Workflow run: https://github.com/DeFiCh/ain/actions/runs/5313674638

@sieniven sieniven marked this pull request as ready for review June 20, 2023 02:35
ci/sync/main.sh Outdated Show resolved Hide resolved
ci/sync/main.sh Outdated Show resolved Hide resolved
ci/sync/main.sh Outdated Show resolved Hide resolved
@Jouzo Jouzo merged commit 3d51c31 into master Jun 21, 2023
@Jouzo Jouzo deleted the niven/test-sync-fix branch June 21, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants