Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Fix create token #2726

Merged
merged 8 commits into from
Nov 29, 2023
Merged

EVM: Fix create token #2726

merged 8 commits into from
Nov 29, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Nov 28, 2023 •
edited
Loading

Summary

  • Fixes create token function call bugs in PR EVM: Fix create token #2686
  • Remove utf-8 encoding check pipeline on cpp side since it is unused.
  • Rename to DF23Height and DF24Height

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven changed the title Niven/fix create token EVM: Fix create token Nov 28, 2023
@sieniven sieniven mentioned this pull request Nov 28, 2023
Closed
9 tasks
@sieniven sieniven mentioned this pull request Nov 29, 2023
Merged
9 tasks
@Bushstar Bushstar merged commit 876a5d1 into master Nov 29, 2023
15 of 16 checks passed
@Bushstar Bushstar deleted the niven/fix-create-token branch November 29, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Bushstar approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @Bushstar @prasannavl