Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Switch to mutex for filters systems #2790

Merged
merged 1 commit into from
Jan 24, 2024
Merged

EVM: Switch to mutex for filters systems #2790

merged 1 commit into from
Jan 24, 2024

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Jan 24, 2024 •
edited
Loading

Summary

  • Switch filters system behind RwLock to Mutex, since RwLock is always write locked with the exposed APIs for updating the filters system.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven changed the title EVM: Switch filters system behind RwLock to Mutex EVM: Switch to mutex for filters systems Jan 24, 2024
@Bushstar Bushstar merged commit db1fe9a into master Jan 24, 2024
15 of 16 checks passed
@Bushstar Bushstar deleted the niven/filters branch January 24, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @Jouzo @Bushstar