-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future Swap limitation #2843
Future Swap limitation #2843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, rest looks good to me
The cost of doing these calc at every block concerns me. This is going to stall the chain esp. on sync catch-up at this block range, which cannot be fixed after the fact as well. We might likely want to just to do the calc at periodic intervals. I don't think accuracy is necessary here. |
valid point. how about doing it every price block (so every 120 blocks)? |
Indeed, that would be perfect. We'll add var that makes the time period changeable. |
Summary
RPCs
listloantokenliquidity
returns a list of all present average liquidity.Implications
Storage
Consensus