Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flag to disable wallet ownership checks #2953

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

prasannavl
Copy link
Member

Summary

  • Adds -dvmownershipcheck flag that to control the enforcement of wallet ownership checks on DVM RPCs
  • Note that the protocol always allows any address to any address.
  • The RPC restrict this to prevent accidental usages, however currently offers no solution to by-pass this.
  • This allows the flag to opt-in when needed.
  • Default remains the same.

DVM RPCs:

  • accounttoaccount
  • utxostoaccount
  • sendtokenstoaddress

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar Bushstar merged commit 46174c4 into master Jun 28, 2024
21 of 26 checks passed
@Bushstar Bushstar deleted the pvl/relax-ownercheck branch June 28, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants