Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterised block time #2955

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Parameterised block time #2955

wants to merge 24 commits into from

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Jun 29, 2024

Summary

  • Move hard coded block time, block period and any other related variables to Gov vars.

Areas impacted moving nTargetSpacing, nTargetTimespanV2 and emissionReductionPeriod to Gov vars

Block time
Difficulty adjust period
Emission reduction
Loans
Auctions
Calculate anchor team
Interest per block
Set pool rewards
Auto updating of daily rewards
Split auto lock
Oracle interval if not set in Gov var

Other areas moved to Gov vars

Anchor auths created chainparams 15 blocks
Anchor team change chainparams 120 blocks
MN Activation chainparams 1008 blocks
MN resignation chainparams 2016 blocks
MN owner, operator, reward change uses MN resignation time
CICXOrder::DEFAULT_EXPIRY 2880
CICXMakeOffer::EUNOSPAYA_DEFAULT_EXPIRY 20
CICXMakeOffer::MAKER_DEPOSIT_REFUND_TIMEOUT 100
CICXSubmitDFCHTLC::EUNOSPAYA_MINIMUM_TIMEOUT 1440
CICXSubmitDFCHTLC::EUNOSPAYA_MINIMUM_2ND_TIMEOUT 480
CICXSubmitEXTHTLC::EUNOSPAYA_BTC_BLOCKS_IN_DFI_BLOCKS 20

Following noted time related areas

Max stake age chainparams 14 * 24 * 60 * 60
Coin age period increment 6 hours
Anchor min depth 3 hours

Other notes:

Limit future swap volume settable via Gov vars, has hard coded defaults if not set.
CFP/VOC set by Gov var. Voting and emergency voting period has defaults in chain params.
Future swap set by Gov var

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl added protocol Has network protocol changes v/next-network-upgrade Items ready or targeted for upcoming network upgrade release(s) p2 Medium priority e4 High effort // takes lot of time or high expertise labels Jul 3, 2024
@prasannavl
Copy link
Member

Currently blocked on missing commits:

Other areas moved to Gov vars
Anchor auths created chainparams 15 blocks
Anchor team change chainparams 120 blocks
MN Activation chainparams 1008 blocks
MN resignation chainparams 2016 blocks
MN owner, operator, reward change uses MN resignation time
CICXOrder::DEFAULT_EXPIRY 2880
CICXMakeOffer::EUNOSPAYA_DEFAULT_EXPIRY 20
CICXMakeOffer::MAKER_DEPOSIT_REFUND_TIMEOUT 100
CICXSubmitDFCHTLC::EUNOSPAYA_MINIMUM_TIMEOUT 1440
CICXSubmitDFCHTLC::EUNOSPAYA_MINIMUM_2ND_TIMEOUT 480
CICXSubmitEXTHTLC::EUNOSPAYA_BTC_BLOCKS_IN_DFI_BLOCKS 20

And then:

  • To ensure they are all set together or errors on set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e4 High effort // takes lot of time or high expertise p2 Medium priority protocol Has network protocol changes v/next-network-upgrade Items ready or targeted for upcoming network upgrade release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants