Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrapper functions #2962

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Use wrapper functions #2962

merged 1 commit into from
Jul 3, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Jul 3, 2024

Summary

  • Do not use newResignDelay or newActivationDelay directly, use GetMnResignDelay or GetMnActivationDelay respectively. Otherwise future changes to resign or activation delays will not be replicated in areas that use the variables directly.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit b2d7309 into master Jul 3, 2024
19 of 26 checks passed
@prasannavl prasannavl deleted the bush/use-resign-helper branch July 3, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bushstar @prasannavl