Fix updateloantoken arguments parsing and description #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouzo
requested review from
Bushstar,
bvbfan,
Mixa84,
monstrobishi,
surangap and
uzyn
as code owners
bvbfan
previously approved these changes
Nov 10, 2021
dcorral
previously approved these changes
Nov 10, 2021
prasannavl
dismissed stale reviews from dcorral and bvbfan
The base branch was changed.
Jouzo
force-pushed
the
fix/updateloantoken_rpc
branch
from
1b812cc
to
120a47b
Compare
|
Had to rebase on other branch, it was a mess though it's only a small PR. |
bvbfan
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Client.cppwere off by one as first argument should be parsed as string.updatetoken.HelpExampleCliand addsHelpExampleRpc