Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorBrowsable(Never) attribute onto fields do not want to use #123

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

Add EditorBrowsable(Never) attribute onto fields do not want to use.
I want to deny access (e.g., internal accessor), but it is inconvenient for testing, so still public.

Note: EditorBrowsable(Never) is not respected on the default preferences of JetBrains Rider.
see: https://youtrack.jetbrains.com/issue/RIDER-17669/Respect-EditorBrowsableEditorBrowsableState.Never

Priority

Very low


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 29, 2024 14:13
@github-actions github-actions bot added the chore label Nov 29, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit 4c3526b into DeNA:master Dec 2, 2024
2 checks passed
@nowsprinting nowsprinting deleted the chore/editor_browsable branch December 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants