Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for Unity 2020 or older #126

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix tests for Unity 2020 or older #126

merged 1 commit into from
Dec 2, 2024

Conversation

nowsprinting
Copy link
Contributor

Fixes

Dispose FileLogHandler before reading the file in tests.
This fixed need for Unity 2020 or older

Priority

Low

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 30, 2024 04:56
@github-actions github-actions bot added the chore label Nov 30, 2024
bo40
bo40 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit e127099 into DeNA:master Dec 2, 2024
2 checks passed
@nowsprinting nowsprinting deleted the chore/fix_filelogger_tests branch December 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40