fix: remove web-ui bugs (#531)

* fix: delete useless cartography checkboxes * fix: check that required fields are not empty or blank * chore: generate not null constraints from liquibase * chore: update required fields with non null value via liquibase sql * chore: update release candidate version
Decathlon · Dec 8, 2021 · 37ee108 · 37ee108
1 parent 398e00f
commit 37ee108
Show file tree

Hide file tree

Showing 30 changed files with 731 additions and 37 deletions.
diff --git a/charts/candidate/Chart.yaml b/charts/candidate/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: ara-candidate
-version: 10.0.0-rc.9
+version: 11.0.0-rc.1
 home: https://github.com/Decathlon/ara
 description: |
     ARA helps you to fight against regressions by letting it preanalyze your non-regression tests runs,

diff --git a/charts/candidate/values.yaml b/charts/candidate/values.yaml
@@ -8,7 +8,7 @@ api:
     image:
         registry: docker.io
         repository: decathlon/ara-api
-        tag: 11.1.4
+        tag: 12.0.0
         imagePullPolicy: IfNotPresent
     loggingMode:
         - logging-console
@@ -47,7 +47,7 @@ ui:
     image:
         registry: docker.io
         repository: decathlon/ara-web-ui
-        tag: 9.3.0
+        tag: 9.3.2
         imagePullPolicy: IfNotPresent
     replicas: 1
     annotations: {}

diff --git a/code/api/api/pom.xml b/code/api/api/pom.xml
@@ -28,7 +28,7 @@
 
     <groupId>com.decathlon.ara</groupId>
     <artifactId>ara-api</artifactId>
-    <version>11.1.4</version>
+    <version>12.0.0</version>
 
     <name>ARA API</name>
     <description>

diff --git a/code/api/database/pom.xml b/code/api/database/pom.xml
@@ -28,7 +28,7 @@
 
     <groupId>com.decathlon.ara</groupId>
     <artifactId>ara-database</artifactId>
-    <version>11.1.4</version>
+    <version>12.0.0</version>
 
     <name>ARA Database</name>
     <description>

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Communication.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Communication.java
@@ -54,14 +54,14 @@ public class Communication implements Comparable<Communication>, Serializable {
     @JoinColumn(name = "project_id")
     private Project project;
 
-    @Column(length = 32)
+    @Column(length = 32, nullable = false)
     private String code;
 
-    @Column(length = 64)
+    @Column(length = 64, nullable = false)
     private String name;
 
     @Enumerated(EnumType.STRING)
-    @Column(length = 4)
+    @Column(length = 4, nullable = false)
     private CommunicationType type;
 
     @Lob

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Country.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Country.java
@@ -41,10 +41,10 @@ public class Country implements Comparable<Country>, Serializable {
 
     private long projectId;
 
-    @Column(length = 2)
+    @Column(length = 2, nullable = false)
     private String code;
 
-    @Column(length = 40)
+    @Column(length = 40, nullable = false)
     private String name;
 
     @Override

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/CycleDefinition.java b/code/api/database/src/main/java/com/decathlon/ara/domain/CycleDefinition.java
@@ -38,12 +38,13 @@ public class CycleDefinition implements Serializable {
 
     private long projectId;
 
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private String branch;
 
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private String name;
 
+    @Column(nullable = false)
     private int branchPosition;
 
 }
diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Project.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Project.java
@@ -43,10 +43,10 @@ public class Project implements Comparable<Project>, Serializable {
     @SequenceGenerator(name = "project_id", sequenceName = "project_id", allocationSize = 1)
     private Long id;
 
-    @Column(length = 32)
+    @Column(length = 32, nullable = false)
     private String code;
 
-    @Column(length = 64)
+    @Column(length = 64, nullable = false)
     private String name;
 
     /**

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/RootCause.java b/code/api/database/src/main/java/com/decathlon/ara/domain/RootCause.java
@@ -40,7 +40,7 @@ public class RootCause implements Serializable {
 
     private long projectId;
 
-    @Column(length = 128)
+    @Column(length = 128, nullable = false)
     private String name;
 
     // No cascade, as this collection is only used while removing a rootCause

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Setting.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Setting.java
@@ -42,7 +42,7 @@ public class Setting implements Comparable<Setting>, Serializable {
     // No access to the parent project entity: settings are obtained from a project, so the project is already known
     private long projectId;
 
-    @Column(length = 64)
+    @Column(length = 64, nullable = false)
     private String code;
 
     @Column(length = 512)

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Severity.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Severity.java
@@ -48,30 +48,31 @@ public class Severity implements Comparable<Severity>, Serializable {
 
     private long projectId;
 
-    @Column(length = 32)
+    @Column(length = 32, nullable = false)
     private String code;
 
     /**
      * The order in which the severities should appear: the lowest position should be for the highest severity.
      */
+    @Column(nullable = false)
     private int position;
 
     /**
      * The full name (eg. "Sanity Check").
      */
-    @Column(length = 32)
+    @Column(length = 32, nullable = false)
     private String name;
 
     /**
      * The shorter name (but still intelligible) to display on table column headers where space is constrained (eg. "Sanity Ch.").
      */
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private String shortName;
 
     /**
      * The shortest name to display on email subjects to help keep it very short (eg. "S.C.").
      */
-    @Column(length = 8)
+    @Column(length = 8, nullable = false)
     private String initials;
 
     /**

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Source.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Source.java
@@ -46,25 +46,26 @@ public class Source implements Comparable<Source>, Serializable {
      * Technical and short code to be used by the build system to send Cucumber-scenarios and Postman-requests as they
      * sit on the Version Control System, for indexation purpose, and for functional coverage computation.
      */
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private String code;
 
     /**
      * Full name displayed in functionality cartography/coverage.
      */
-    @Column(length = 32)
+    @Column(length = 32, nullable = false)
     private String name;
 
     /**
      * Unique recognizable letter to be displayed in functionality cartography/coverage where space is very limited.
      */
+    @Column(nullable = false)
     private char letter;
 
     /**
      * The technology used for tests stored in this VCS source: Cucumber .feature files, Postman .json collections...
      */
     @Enumerated(EnumType.STRING)
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private Technology technology;
 
     /**
@@ -75,12 +76,13 @@ public class Source implements Comparable<Source>, Serializable {
      *
      * @see #defaultBranch defaultBranch used to replace "{{branch}}" when indexing functionalities coverage
      */
+    @Column(nullable = false)
     private String vcsUrl;
 
     /**
      * The primary reference branch to use with {@link #vcsUrl} when indexing functionalities coverage.
      */
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private String defaultBranch;
 
     /**

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Team.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Team.java
@@ -42,7 +42,7 @@ public class Team implements Serializable {
 
     private long projectId;
 
-    @Column(length = 128)
+    @Column(length = 128, nullable = false)
     private String name;
 
     private boolean assignableToProblems;

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/TechnologySetting.java b/code/api/database/src/main/java/com/decathlon/ara/domain/TechnologySetting.java
@@ -41,10 +41,12 @@ public class TechnologySetting implements Comparable<TechnologySetting>, Seriali
 
     private Long projectId;
 
+    @Column(nullable = false)
     private String code;
 
     private String value;
 
+    @Column(nullable = false)
     @Enumerated(EnumType.STRING)
     private Technology technology;
 

diff --git a/code/api/database/src/main/java/com/decathlon/ara/domain/Type.java b/code/api/database/src/main/java/com/decathlon/ara/domain/Type.java
@@ -41,10 +41,10 @@ public class Type implements Comparable<Type>, Serializable {
 
     private long projectId;
 
-    @Column(length = 16)
+    @Column(length = 16, nullable = false)
     private String code;
 
-    @Column(length = 50)
+    @Column(length = 50, nullable = false)
     private String name;
 
     private boolean isBrowser;
@@ -58,7 +58,7 @@ public class Type implements Comparable<Type>, Serializable {
      * created to indicate it is not an mis-configuration.
      */
     @ManyToOne(fetch = FetchType.LAZY)
-    @JoinColumn(name = "source_id")
+    @JoinColumn(name = "source_id", nullable = false)
     private Source source;
 
     @Override

diff --git a/...abase/src/main/resources/db/changelog/changes/h2/20211125174155-not_null_constraints.yaml b/...abase/src/main/resources/db/changelog/changes/h2/20211125174155-not_null_constraints.yaml
@@ -0,0 +1,50 @@
+databaseChangeLog:
+- changeSet:
+    id: 1637858656728-1
+    author: '? (generated)'
+    changes:
+    - modifyDataType:
+        columnName: COMMENT
+        newDataType: varchar(2147483647)
+        tableName: FUNCTIONALITY
+- changeSet:
+    id: 1637858656728-2
+    author: '? (generated)'
+    changes:
+    - modifyDataType:
+        columnName: COMMENT
+        newDataType: varchar(2147483647)
+        tableName: PROBLEM
+- changeSet:
+    id: 1637858656728-3
+    author: '? (generated)'
+    changes:
+    - modifyDataType:
+        columnName: CONTENT
+        newDataType: varchar(2147483647)
+        tableName: EXECUTED_SCENARIO
+- changeSet:
+    id: 1637858656728-4
+    author: '? (generated)'
+    changes:
+    - modifyDataType:
+        columnName: CONTENT
+        newDataType: varchar(2147483647)
+        tableName: SCENARIO
+- changeSet:
+    id: 1637858656728-5
+    author: '? (generated)'
+    changes:
+    - modifyDataType:
+        columnName: EXCEPTION
+        newDataType: varchar(2147483647)
+        tableName: PROBLEM_PATTERN
+- changeSet:
+    id: 1637858656728-6
+    author: '? (generated)'
+    changes:
+    - modifyDataType:
+        columnName: MESSAGE
+        newDataType: varchar(2147483647)
+        tableName: COMMUNICATION
+