Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : thread block on some unix system when creating demo project #615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rossignolloic
Copy link
Contributor

@rossignolloic rossignolloic commented May 5, 2022

Type of modification

  • Breaking change
  • New Feature
  • Bug Fix
  • Chore (refactor, documentation, tests... all the changes with no impact on ARA functionalities.)

Technical description

The use of SecureRandom.getInstanceStrong() has been replace by new Random(). SecureRandom.getInstanceStrong() can lead to blocked Thread, new Random() doesn't have this problem and is sufficient for generating demo data.

PR CheckList

Please make sure your PullRequest respect all those items :

  • Your PR's title has the prefix : feat:, fix: or chore:
  • You have asked a review from one of the ARA maintainer in your PR.
  • If your PR is related to an issue, add the issue's number in it.
  • All the code you added is documented.
  • All the code you added is tested and the tests are in success.
  • You already signed the Contributor License Agreement and give us the document

@rossignolloic rossignolloic force-pushed the fix/threadBlockedOnDemoCreation branch from 810b485 to cd71f18 Compare May 5, 2022 08:37
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

[ARA core-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

[ARA web-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

[ARA api] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


z15lross seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants