Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vscode extension : Prevent Goals panel to take focus when browsing proofs #1134

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Alidra
Copy link
Member

@Alidra Alidra commented Sep 23, 2024

As described in this discussion of issue #869, the Goals panel of the Vscode extension tends to take focus when user is executing commands in a Lambdapi file. This PR fixes this issue and removes a debugging message that is no more needed.

@Alidra Alidra added the vscode Issues related to Vscode plugin label Sep 23, 2024
@Alidra Alidra requested a review from fblanqui September 23, 2024 09:59
@Alidra Alidra self-assigned this Sep 23, 2024
@fblanqui
Copy link
Member

It looks fine to me but I cannot test it right now. Let me know when you want me to merge it.

@Alidra
Copy link
Member Author

Alidra commented Sep 23, 2024

I believe it is ready to merge (just tested again). Please approve @fblanqui

@fblanqui fblanqui merged commit a83b469 into Deducteam:master Sep 24, 2024
11 checks passed
@mikemull
Copy link

fwiw, this works perfectly for me. Many thanks @Alidra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode Issues related to Vscode plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants