Fix fs_time check for number of arguments and line duplication in recon-surf #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs_time was terminating when only one command and no arguments to that command were passed ("$#" == 1).
This check was also duplicated with a later check in the script where the length of $cmd is checked.
> if [[ "${#cmd[@]}" == 0 ]]
Removing the first check in favor of this second, more descriptive and robust check.
…ll_fs_pruned.sh. These are likely git rebase/merge corruptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in recon_surf that caused errors, if --parallel was not passed. This Bug was reported in #543 .
It also addresses duplicate lines in recon-surf.sh, which seems to be a rebase artifact.