-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating Quicktest to PyTest and adding dockerized self hosted runner #549
Conversation
@dkuegler requesting review |
@dkuegler requesting review after suggested fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not really checked test_images or test_stats yet, changes from other files should probably be applied there first too .
Please clean up/squash the git history a bit. |
64b9c6c
to
876d767
Compare
Please also apply changes from the reviews and clean up the git history. |
19fa7f8
to
4be5147
Compare
4be5147
to
3c40791
Compare
@dkuegler please review |
c669fa8
to
8501c47
Compare
- added support for multiple test subjects and parameterization in all tests - reorganized file structure - separate stats files for each aseg and aparc+DKT - moving fixtures and common functions to common.py and conftest.py quicktest_runner.yaml: - removed check-output job - added THIS_RUN_DIR to seperate different runs
- documentation fixes in quicktest.yaml - docstring fixes in test_errors_in_logfiles.py - removed loop over assert in test_file_existence.py
af9be34
to
6538b5a
Compare
@dkuegler please review again |
6538b5a
to
402bcc6
Compare
402bcc6
to
c00e2f4
Compare
… thus simplifying, and streamlining the workflow and improving execution time significantly. Adding Labelled output directories for each run Removing unnecessary import statements from pytest files Cleaning up code: - migrating from os.path.join to pathlib Path - changing str to Path - cleaning up comments and docstrings - ran ruff on code to fix code style
c00e2f4
to
810a170
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor fixes required before we merge. Generally, we need to make sure when we merge the commit, it passes the test itself.
e8aff44
to
054ea58
Compare
added tests for:
migrated tests from unittest to pytest framework
changed fastsurfer to run multiple subjects
added new workflow (quicktest_runner) to run on dockerized self-hosted runner