-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dev into stable for new release #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding periods and underscores to the package_pattern to allow Python packages with those characters (allowable in pypi) to be added to environment YAMLs
Remaining rst files added, README.md file split Fixing label duplication warnings and other warnings Requested changes applied pyproject.toml and doc.yml file added to trigger sphinx workflow Added all READMD.md files
fix optional dependencies
Add myst parser
add sklearn, skimage, torchvision in pyproject.toml
Fix all warm import
Remove Executor as a parent to serial executor.
Consistently introduce the Plane Type to FastSurferCNN.utils Some formatting fixes across multiple files fix extract_recon_surf_time_info.py
Remove Executor from `__all__`
Revert inheritance
replace .A and .A1 with explicit array conversion
fix things for Mac and MPS
Because allow_root is always set to False, root is not compatible with computing stats for hypvinn. This changes root to True, which is suboptimal, but fine. This is only a check in segstats and it is also already checked in run_prediction before (so this is redundant).
BUG: --allow_root does not work for segstats module in hypvinn.
… FastSurfer does not detect it there. Add Code to run_fastsurfer, that detects the license from FREESURFER_HOME. Also add an environment variable to deactivate this search from inside a container.
The FreeSurfer license is often in the FREESURFER_HOME directory, but FastSurfer does not detect it there.
The doc workflow deployed to the root folder of gh_pages, not to dev or stable subdirectories. This PR fixes the subdirectory the action pushes to by fixing the github-event variable (github.ref_name instead of github.event.ref_name).
Fix the target directory of the doc workflow
Add rocm as a valid device option to build.py fix typo install_env.py for rocm remove extra } in export_pip-r.sh Fix Docker build for cuda 11.8 Add weights_only=True for torch.load to clean up torch warnings. Fix delim_whitespace warning in data_utils.py Fix AMD ROCm documentation.
The SUBJECTS_DIR/IMAGE_ID/scripts/build.log file currently only contains the information "specifically requested", which on principle only is the version number. This commit fixes the parameters to the version script, so build.log contains the expected information such as python packages, model checkpoints and git status.
Fix content of buildlog file
removing isort and black in favour of ruff
export requirements.txt and requirements.cpu.txt from respective docker images
update versions of python packages
Fix the run time calculation (rounded to integer hours in log file)
Fixes error introduced in 2f350e9
Fix the run time calculation (rounded to integer hours in log file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.