Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional types converted to null #656

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

TahaKhanAbdalli
Copy link
Collaborator

@TahaKhanAbdalli TahaKhanAbdalli commented Aug 21, 2023

Types are converted to null but mock localForage still needs undefined.

Fixes #504

@IanMayo IanMayo temporarily deployed to rco-review-pr-656 August 21, 2023 14:12 Inactive
@IanMayo IanMayo temporarily deployed to rco-review-pr-656 August 21, 2023 15:22 Inactive
@IanMayo IanMayo temporarily deployed to rco-review-pr-656 August 21, 2023 16:57 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IanMayo
Copy link
Contributor

IanMayo commented Aug 21, 2023

Ok, @TahaKhanAbdalli - could you have a look at my changes please?

I've tried to ensure full JS object gets created, with relevant null fields. I'm also trying to handle providing the correct filter operator.

@TahaKhanAbdalli
Copy link
Collaborator Author

Ok, @TahaKhanAbdalli - could you have a look at my changes please?

I've tried to ensure full JS object gets created, with relevant null fields. I'm also trying to handle providing the correct filter operator.

Yes. It seems ok and it's working as expected.

@IanMayo IanMayo merged commit 42603ae into main Aug 22, 2023
@IanMayo IanMayo deleted the types_changed_optional_to_null branch August 22, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operators required for REST backend
2 participants