-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zh-hant to OpenAPI spec for text translation #22
Conversation
Not approving yet because of my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should bump the minor version number up. Can you do this Mike?
@daniel-jones-dev just bumped to 3.0.4, let me know if all looks as you expect it to and I can go ahead and merge! |
Hmmm that is the wrong version number. 3.0.3 here is the OpenAPI specification version (i.e. what fields should be present in the openapi.* files). Lastly, a minor version bump means the second number, i.e. the next version would be 2.16.0. Edit: Sorry this is not clear; we need to add some developer documentation to the project. |
@daniel-jones-dev sorry, my mistake! Just pushed what should be a fix. |
I forgot to mention: when bumping the version number, it's important to update the changelog too -- I've just done that. |
@daniel-jones-dev FYI, I also added the separate TargetLanguagesText list to the openapi_gitbook file.