Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-hant to OpenAPI spec for text translation #22

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

mike-winters-deepl
Copy link
Member

@daniel-jones-dev FYI, I also added the separate TargetLanguagesText list to the openapi_gitbook file.

openapi_gitbook.yaml Show resolved Hide resolved
openapi.json Outdated Show resolved Hide resolved
@JanEbbing
Copy link
Member

Not approving yet because of my TargetLanguage question, rest LGTM

Copy link
Member

@daniel-jones-dev daniel-jones-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should bump the minor version number up. Can you do this Mike?

@mike-winters-deepl
Copy link
Member Author

LGTM. We should bump the minor version number up. Can you do this Mike?

@daniel-jones-dev just bumped to 3.0.4, let me know if all looks as you expect it to and I can go ahead and merge!

@daniel-jones-dev
Copy link
Member

daniel-jones-dev commented Jul 25, 2024

LGTM. We should bump the minor version number up. Can you do this Mike?

@daniel-jones-dev just bumped to 3.0.4, let me know if all looks as you expect it to and I can go ahead and merge!

Hmmm that is the wrong version number. 3.0.3 here is the OpenAPI specification version (i.e. what fields should be present in the openapi.* files).
The 2.15.0 here is the DeepL API version i.e. reflecting how the API behaviour is changing.

Lastly, a minor version bump means the second number, i.e. the next version would be 2.16.0.

Edit: Sorry this is not clear; we need to add some developer documentation to the project.

@mike-winters-deepl
Copy link
Member Author

@daniel-jones-dev sorry, my mistake! Just pushed what should be a fix.

@daniel-jones-dev
Copy link
Member

I forgot to mention: when bumping the version number, it's important to update the changelog too -- I've just done that.

@daniel-jones-dev daniel-jones-dev merged commit fed2755 into main Jul 25, 2024
1 check passed
@daniel-jones-dev daniel-jones-dev deleted the add-zh-hant-support branch July 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants