Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACL-949] Add show_billed_characters parameter to OpenAPI spec #24

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

mike-winters-deepl
Copy link
Member

No description provided.

@mike-winters-deepl
Copy link
Member Author

@daniel-jones-dev I think we'll need to run the script to update the .json file, if that doesn't happen automatically.

seekuehe
seekuehe previously approved these changes Sep 10, 2024
openapi.yaml Outdated Show resolved Hide resolved
Copy link
Member

@daniel-jones-dev daniel-jones-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from the two minor comments.

PS: The GH action will take of updating the JSON file.

@mike-winters-deepl
Copy link
Member Author

mike-winters-deepl commented Sep 10, 2024

@daniel-jones-dev re-tagging you for approval after pushing the changes you suggested.

@mike-winters-deepl
Copy link
Member Author

@daniel-jones-dev @seekuehe I think I need a re-review due to making some copy changes before I can merge.

openapi.json Outdated Show resolved Hide resolved
openapi_gitbook.yaml Outdated Show resolved Hide resolved
@JanEbbing
Copy link
Member

Rest looks good to me 👍

@mike-winters-deepl
Copy link
Member Author

@JanEbbing could you please re-review? I think we're good on the alphabetization of schemas now.

Copy link
Member

@JanEbbing JanEbbing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM!

@mike-winters-deepl mike-winters-deepl merged commit 1895887 into main Sep 13, 2024
@mike-winters-deepl mike-winters-deepl deleted the show-billed-characters branch September 13, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants