-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACL-949] Add show_billed_characters parameter to OpenAPI spec #24
Conversation
@daniel-jones-dev I think we'll need to run the script to update the .json file, if that doesn't happen automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, aside from the two minor comments.
PS: The GH action will take of updating the JSON file.
71f71bc
@daniel-jones-dev re-tagging you for approval after pushing the changes you suggested. |
@daniel-jones-dev @seekuehe I think I need a re-review due to making some copy changes before I can merge. |
Rest looks good to me 👍 |
@JanEbbing could you please re-review? I think we're good on the alphabetization of schemas now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, LGTM!
No description provided.