Implement rotary_embedding for Ascend #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfxu-st
requested review from
hellozmz,
zhangzefeng92 and
yangbofun
as code owners
hellozmz
approved these changes
Dec 19, 2023
yangbofun
reviewed
Dec 20, 2023
| namespace OP_IMPL_NS { | ||
|
|
||
| DIOPI_API diopiError_t diopiRotaryEmbedding(diopiContextHandle_t ctx, diopiTensorHandle_t out, diopiConstTensorHandle_t x, diopiConstTensorHandle_t cos, | ||
| diopiConstTensorHandle_t sin, const bool conj, const bool interleaved) { |
There was a problem hiding this comment.
对interleaved做一次检查，对不满足的情况，打个报错日志。
There was a problem hiding this comment.
对interleaved做一次检查，对不满足的情况，打个报错日志。
Done
yangbofun
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation and Context
The rotary_embedding op is not implemented on Ascend.
Description
Implement rotary_embedding for Ascend
Use cases (Optional)
BC-breaking (Optional)
Checklist
Before PR:
After PR: