Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] License List 관련 Build 오류 수정 #24

Merged
merged 5 commits into from
Jul 5, 2023
Merged

[FIX] License List 관련 Build 오류 수정 #24

merged 5 commits into from
Jul 5, 2023

Conversation

rdg1029
Copy link
Contributor

@rdg1029 rdg1029 commented Jul 5, 2023

Summary

License List와 관련된 빌드 오류 문제를 해결했습니다.

Description

  • LicenseListAll 컴포넌트에서 누락된 key 속성 적용
  • LicenseListByClass 컴포넌트에서 누락된 key 속성 적용
  • LicenseListByType 컴포넌트에서 누락된 key 속성 적용
  • LicenseListInOrder 컴포넌트에서 누락된 key 속성 적용
  • ListPage 컴포넌트에서 마운트 상태 확인 후 렌더링 하는 방식으로 적용

@rdg1029 rdg1029 added the fix Something isn't working label Jul 5, 2023
@rdg1029 rdg1029 self-assigned this Jul 5, 2023
@rdg1029 rdg1029 linked an issue Jul 5, 2023 that may be closed by this pull request
[FIX] License List 관련 Build 불가 #23
Closed
yymin1022
yymin1022 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@yymin1022 yymin1022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!
이후로는 각 Pull Request 작성 이전에 Local 환경에서 Build 테스트 한번 진행해주세요!
@rdg1029 @HarenKei

HarenKei
HarenKei approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@HarenKei HarenKei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@yymin1022 yymin1022 merged commit 9573e17 into DefCon-Apps:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yymin1022 yymin1022 yymin1022 approved these changes

@HarenKei HarenKei HarenKei approved these changes

Assignees

@rdg1029 rdg1029

Labels
fix Something isn't working
Projects
Military License
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] License List 관련 Build 불가
3 participants
@rdg1029 @yymin1022 @HarenKei