Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings in @reach/router to include innerRef #43367

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

Eyas
Copy link
Contributor

@Eyas Eyas commented Mar 24, 2020

https://reach.tech/router/api/Link

innerRef: func

Calls up with its inner ref for apps on React <16.4.
If using React >=16.4, use ref instead.

<Link to="./" innerRef={node => /* ... */} />

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://reach.tech/router/api/Link
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. N/A
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed. N/A

Eyas added 2 commits March 24, 2020 14:54
https://reach.tech/router/api/Link

> ## innerRef: func
> Calls up with its inner ref for apps on React <16.4.
> If using React >=16.4, use ref instead.
>
> ```
> <Link to="./" innerRef={node => /* ... */} />
> ```
@typescript-bot typescript-bot added Where is Travis? Popular package This PR affects a popular package (as counted by NPM download counts). labels Mar 24, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 24, 2020

@Eyas Thank you for submitting this PR!

🔔 @kingdaro @xMokAx @awwit @wroughtec @chilledoj - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

@Eyas - It appears Travis did not correctly run on this PR! /cc @RyanCavanaugh to investigate and advise.

@Eyas
Copy link
Contributor Author

Eyas commented Mar 27, 2020

@sandersn @RyanCavanaugh Travis has been running for a day, locally, npm test has been running for an hour+.

I'm starting to think there's an infintie loop somewhere in the dependency testing, could that be?

@Eyas
Copy link
Contributor Author

Eyas commented Mar 27, 2020

hm actually the travis link shows this completed successfully since yesterday, but still shows up here as running.

@sandersn
Copy link
Contributor

Odd, because the bot removed the tag, so it also noticed that Travis succeeded.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Mar 29, 2020
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants