[@testing-library/jest-dom] Allow all elements

[nickserv]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: React Testing Library API types prevent usage of SVG elements testing-library/react-testing-library#830
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@nickmccurdy Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• testing-library__jest-dom on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 23 days — it is considered nearly abandoned!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 49707,
  "author": "nickmccurdy",
  "headCommitOid": "abfb39f187b6cc60fa7f93f2fc7abeeea102a5ca",
  "lastPushDate": "2020-11-20T21:11:16.000Z",
  "lastActivityDate": "2020-12-24T02:14:15.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "testing-library__jest-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/testing-library__jest-dom/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "gnapse",
        "jgoz",
        "smacpherson64"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "jgoz",
      "date": "2020-11-20T21:31:10.000Z"
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @gnapse @jgoz @smacpherson64 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[jgoz]

Hmm, I don't believe this change reflects the actual runtime behavior in jest-dom. Both of these methods use checkHtmlElement which explicitly verifies that they are instances of either HTMLElement or SVGElement.

The linked issue in react-testing-library discussed allowing elements such as <circle> to be used directly, which are not instances of either of these two prototypes.

Therefore, I think the correct order of operations would be to first open a PR in jest-dom to make these assertions compatible with the non-root SVG elements, and then reflect that in the typings.

[typescript-bot]

@nickmccurdy One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#49707	diff
Batch compilation
Memory usage (MiB)	83.0	81.6	-1.7%
Type count	11518	11516	0%
Assignability cache size	3721	3721	0%
Language service
Samples taken	312	312	0%
Identifiers in tests	312	312	0%
getCompletionsAtPosition
Mean duration (ms)	324.7	325.8	+0.3%
Mean CV	10.7%	11.0%
Worst duration (ms)	420.2	431.3	+2.6%
Worst identifier	not	toHaveTextContent
getQuickInfoAtPosition
Mean duration (ms)	326.1	326.0	0.0%
Mean CV	10.0%	9.9%
Worst duration (ms)	426.8	408.7	-4.2%
Worst identifier	expect	toHaveTextContent

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[nickserv]

I thought we could go without this, but it seems like Jest DOM's runtime type checking has gotten out of sync with other type updates we've made in the organization. To remedy this I've opened testing-library/jest-dom#313 upstream. Once that's fixed I may update this pull request.

[typescript-bot]

@nickmccurdy I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed in a week if the issues aren't addressed.

[nickserv]

Intentionally keeping this open as it's blocked by testing-library/jest-dom#313

[typescript-bot]

@nickmccurdy I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Feb 15 (in a week) if the issues aren't addressed.

[nickserv]

This is still blocked but I'll close it temporarily to stop the bot from replying.