Push ServeSession to the start #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as this is more fleshed out, more will be backfilled
boatbomber
suggested changes
Jul 28, 2023
Wording and stylization fixes. Fix misconception about plugin. Co-authored-by: boatbomber <zack@boatbomber.com>
Dekkonot
requested changes
Jul 28, 2023
Editorial changes and clarifications. Co-authored-by: Micah <dekkonot@rocketmail.com>
Dekkonot
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basis comes from this comment from the main PR.
I need to move the description I put forServeSessionto the Data Structure section. I wrote on "what needs to be described first", so /shrug.Maybe we should describe each command in its own part under the Overarching section. It is the entry point for Rojo, after all.