Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api #62

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Feat/api #62

merged 4 commits into from
Jul 31, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Jul 31, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced authentication process with login flow and conditional navigation based on mnemonic status.
    • New API functionalities for managing mnemonics and public keys, including creation, retrieval, and deletion.
    • Introduced structured error handling with specific error codes related to wallet operations.
  • Bug Fixes

    • Improved navigation logic in the LoginPage and OidcLoginPage components to better handle user authentication states.
  • Documentation

    • Updated comments and configuration options in .env.development to aid local development.
  • Chores

    • Added package-lock.json to .gitignore to streamline version control.

Copy link

coderabbitai bot commented Jul 31, 2024

Walkthrough

The recent changes enhance the authentication and user experience within the wallet application. Key updates include the introduction of new API request methods, improvements in error handling, and refinements to component logic, such as transitioning from connection-based to login-based states. The modifications streamline user flows for password management and mnemonic handling, ensuring better security and clarity in operations while enhancing the overall flexibility of the application.

Changes

Files Change Summary
.gitignore Added package-lock.json to be ignored.
apps/wallet/.env.development Added a commented alternative URL for local development authentication server.
apps/wallet/src/App.tsx Replaced connect method with login for clearer user authentication flow; introduced navigation based on mnemonic state.
apps/wallet/src/apis/index.ts Added authApiRequest and new service functions for handling authentication requests and error management.
apps/wallet/src/apis/models.ts Introduced new interfaces and classes for managing mnemonic data and error responses.
apps/wallet/src/apis/services/auth.ts New async functions for managing mnemonics and public keys.
apps/wallet/src/pages/login/index.tsx Updated condition checks to leverage isLoggedIn instead of isConnected.
apps/wallet/src/pages/oidc-login/index.tsx Simplified control flow by removing unnecessary login handling code.
apps/wallet/src/pages/password/create.tsx Enhanced password creation logic with cryptographic operations and error handling.
apps/wallet/src/pages/password/index.tsx Modified component to handle multiple password-related functionalities with a versatile type prop.
apps/wallet/src/pages/password/verify.tsx Introduced new component for verifying wallet passwords with robust validation and state management.
apps/wallet/src/stores/session.ts Significant enhancements in HibitIdSession class for improved user session management and security practices.
apps/wallet/src/utils/auth/providers/telegram.ts Updated URL handling logic in TelegramAuthenticateProvider.
apps/wallet/src/utils/error-code.ts Added structured error handling with enums and utility functions.
apps/wallet/vite.config.ts Made formatting adjustments to imports and configuration comments.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant AuthService
    participant Api

    User->>App: Login
    App->>AuthService: Call login()
    AuthService->>Api: Send authentication request
    Api-->>AuthService: Return response
    AuthService-->>App: Return login status
    App-->>User: Redirect based on login state
Loading
sequenceDiagram
    participant User
    participant App
    participant AuthService
    participant Api

    User->>App: Create Password
    App->>AuthService: Call submitMutation(password)
    AuthService->>Api: Send hashed password and mnemonic
    Api-->>AuthService: Return creation status
    AuthService-->>App: Return creation result
    App-->>User: Show success or error message
Loading

Poem

🐇 In the land of code where rabbits play,
We've spruced up our paths, oh what a day!
With logins now clear and mnemonics in sight,
Our wallet's more secure, everything feels right.
Hops of excitement, new features to cheer,
Let's code and create, for the future is near! 🌟


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-ae6yxz4xn-delandlabs-projects.vercel.app

Built with commit a0b26e2.
This pull request is being automatically deployed with vercel-action

@rustin01 rustin01 merged commit 7d30bde into main Jul 31, 2024
2 checks passed
@rustin01 rustin01 deleted the feat/api branch July 31, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants