Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: change password api #64

Merged
merged 1 commit into from
Jul 31, 2024
Merged

✨ feat: change password api #64

merged 1 commit into from
Jul 31, 2024

Conversation

rustin01
Copy link
Contributor

@rustin01 rustin01 commented Jul 31, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new functionality for updating mnemonics and securely changing user passwords.
    • Enhanced password reset process with improved error handling and user feedback.
  • Bug Fixes

    • Addressed issues in the password reset logic by refining the mutation parameters and feedback mechanisms.
  • Improvements

    • Simplified the encryption format for generated phrases and ensured better handling during the password update process.

Copy link

coderabbitai bot commented Jul 31, 2024

Walkthrough

The recent updates enhance the wallet application's functionality by introducing robust management for mnemonic updates and improving password reset processes. New classes and methods for handling mnemonic data have been added, along with improved error handling in the password reset flow. The changes aim to streamline user interactions and ensure better data integrity across the application.

Changes

File Path Change Summary
apps/wallet/src/apis/models.ts Added UpdateMnemonicInput and UpdateMnemonicResult classes for managing mnemonic updates.
apps/wallet/src/apis/services/auth.ts Introduced UpdateMnemonicAsync function for updating mnemonics; updated public key retrieval endpoint.
apps/wallet/src/pages/password/reset.tsx Refactored password reset mutation logic and added error handling for improved user feedback.
apps/wallet/src/stores/session.ts Enhanced HibitIdSession with updatePassword method for secure password changes; updated imports for mnemonic management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AuthService
    participant SessionStore
    participant MnemonicInput

    User->>AuthService: Update mnemonic request
    AuthService->>MnemonicInput: Validate input
    MnemonicInput->>AuthService: Return input validity
    AuthService->>SessionStore: Update mnemonic in session
    SessionStore-->>AuthService: Confirmation
    AuthService-->>User: Return update result
Loading

🐇🌟 "In the code where changes hop,
New mnemonics in a jolly swap.
Passwords refreshed, errors caught,
A bunny’s joy in each new thought!
With every line, the functions play,
Hooray for updates, hip-hip-hooray!" 🌟🐇


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustin01 rustin01 merged commit 5350fcc into main Jul 31, 2024
2 checks passed
@rustin01 rustin01 deleted the feat/change-password-api branch July 31, 2024 12:43
Copy link

Deploy preview for hibit-id ready!

✅ Preview
https://hibit-i5ft0hlak-delandlabs-projects.vercel.app

Built with commit 195bf2f.
This pull request is being automatically deployed with vercel-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant