-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: removed snyk issues involving OIDC #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add a changie entry of type security that communicates the value of this for those reading release notes on github.
- Change title to
security
type, not fix.
Mark this done and then I'll get that approved. Cheers!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 32.61% 25.29% -7.32%
==========================================
Files 80 79 -1
Lines 10855 11088 +233
==========================================
- Hits 3540 2805 -735
- Misses 7027 8012 +985
+ Partials 288 271 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. minor improvement to wording as this is merged into a final doc and meant for consumers primarily, so I simplified and fixed casing. Thanks @pacificcode!
Snyk check failure is due to vendored code, so upon reimport this will go away, so leaving alone. Request reimport of the repository by the security team to have this go away. Thanks! |
@sheldonhull Security team? can you be a little more specific or maybe a person to point this re-import to? |
removed writing empty req.body to httpWriter in OIDC authentication.
modified ras.GenerateKey to use 2048 bit encryption in cicd-integration/generate_pki.go