Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shark Race - Feroxi #1669

Open
wants to merge 79 commits into
base: master
Choose a base branch
from

Conversation

BlitzTheSquishy
Copy link
Contributor

@BlitzTheSquishy BlitzTheSquishy commented Aug 23, 2024

About the PR

Adding a new race! One that as far as I recall its "type" not present in any English SS14 server, that being aquatic species.

Why / Balance

Well, we lack any true aquatic type species, though lizards can be argued to be semiaquatic in terms of salamanders, and aquatic markings, its not really versatile for the purpose of other aquatic types. Though the base of this race WILL be for sharks, they could very well be adapted to other fish, and even dolphins and whales if one so desired!

Technical details

Addition of a new system and component to allow for a somewhat unique mechanic for this race based on its thirst. Flipping the metabolizer when a certain point is met with the thirst threshold.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Feroxi are here! A collection of shark-like peoples, who can use Water Vapor instead of oxygen!

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

RSI Diff Bot; head commit 5871c29 merging into 7200dfb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Effects/creampie.rsi

State Old New Status
creampie_feroxi Added

Resources/Textures/DeltaV/Effects/speech.rsi

State Old New Status
feroxi0 Added
feroxi1 Added
feroxi2 Added

Resources/Textures/DeltaV/Mobs/Customization/Feroxi/body_markings.rsi

State Old New Status
feroxi-arm-stripes-blitz Added
feroxi-leg-stripes-blitz Added
feroxi-torso-stripes-blitz Added

Resources/Textures/DeltaV/Mobs/Customization/Feroxi/ear_markings.rsi

State Old New Status
feroxi-ears-inner Added
feroxi-ears-tips Added
feroxi-ears Added

Resources/Textures/DeltaV/Mobs/Customization/Feroxi/masking_helpers.rsi

State Old New Status
female_full Added
female_none Added
female_top Added
full Added
male_full Added
male_none Added
male_top Added
none Added
top Added
unisex_full Added
unisex_none Added
unisex_top Added

Resources/Textures/DeltaV/Mobs/Customization/Feroxi/snout_markings.rsi

State Old New Status
feroxi-snout-stripe Added
feroxi-snout Added

Resources/Textures/DeltaV/Mobs/Customization/Feroxi/tail_markings.rsi

State Old New Status
feroxi-dorsal-stripes Added
feroxi-dorsal-tip Added
feroxi-dorsal Added
feroxi-tail-bottom-tip Added
feroxi-tail-second-dorsal-tip Added
feroxi-tail-stripes Added
feroxi-tail-top-tip Added
feroxi-tail-under Added
feroxi-tail Added

Resources/Textures/DeltaV/Mobs/Species/Feroxi/parts.rsi

State Old New Status
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Edit: diff updated after 5871c29

@BlitzTheSquishy
Copy link
Contributor Author

Something about i like sharks, idk

draft pr cause im stupid and this will take me a while (as well as needing people help)

currently for a base uses a mix of human and vulpkanin stuff...

THIS IS DEFINITELY A MESS

@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Aug 23, 2024
@BlitzTheSquishy BlitzTheSquishy changed the title Shark race delta v (oh god this is actual pain) locales are cool Aug 23, 2024
@BlitzTheSquishy BlitzTheSquishy changed the title locales are cool Shark race delta v (oh god this is actual pain Aug 23, 2024
@BlitzTheSquishy
Copy link
Contributor Author

oops

@jimmy12or
Copy link
Contributor

Oh! With rodents and IPCs likely joining in the near future, looks like the sharks have smelled the metaphorical blood in the water! Welcome, aquatic scaled friends!

@BlitzTheSquishy
Copy link
Contributor Author

Oh! With rodents and IPCs likely joining in the near future, looks like the sharks have smelled the metaphorical blood in the water! Welcome, aquatic scaled friends!

Been planning to get these added for AAAAGES

also as far as I can tell this would be the first for aquatic friendos to exist on any ss14 server (unless one of the russian ones already has akula)

@Tmanzxd
Copy link

Tmanzxd commented Aug 27, 2024

Do you have a list of items you want to complete for this Morphotype?

@BlitzTheSquishy
Copy link
Contributor Author

Do you have a list of items you want to complete for this Morphotype?

when i die :3

a few things

Damage resist/vuln are basically done
Suffocation when in that yellow tier of thirst
thorsty is also basically done

Not sure of upsides just yet

@github-actions github-actions bot added the Changes: Documentation Changes any xml or md files label Aug 27, 2024
@BlitzTheSquishy BlitzTheSquishy changed the title Shark race delta v (oh god this is actual pain Shark race delta v (oh god this is actual pain) Aug 27, 2024
@BlitzTheSquishy BlitzTheSquishy changed the title Shark race delta v (oh god this is actual pain) Shark Race - Feroxi Aug 28, 2024
@BlitzTheSquishy
Copy link
Contributor Author

I do need ideas for upsides!

@jimmy12or
Copy link
Contributor

Maybe able to sate hydration while in an area with water vapor? Very niche, I know but it would at least be something small that could be added.

@Tmanzxd
Copy link

Tmanzxd commented Aug 29, 2024

you could make them regenerate brute damage slightly faster

@github-actions github-actions bot added the size/XL Over 1024 lines label Nov 28, 2024
@BlitzTheSquishy
Copy link
Contributor Author

I think thats all of the reviews?

Markings are still TBD

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Blitz <73762869+BlitzTheSquishy@users.noreply.github.com>
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Nov 29, 2024
@ewokswagger
Copy link
Contributor

whats the status on this? This looks so cool!

@Campbelle1000
Copy link

I know right? It's super cool!

@fow111
Copy link

fow111 commented Dec 14, 2024

seems fishy

@BlitzTheSquishy
Copy link
Contributor Author

whats the status on this? This looks so cool!

Sprites hard :c

thats the status

@BlitzTheSquishy BlitzTheSquishy requested a review from a team as a code owner December 16, 2024 11:44
@Campbelle1000
Copy link

Oh I feel ya on that one, spriting can be awful.
Best of luck, we all look forward to your progress.
Aye maybe we can do an underwater station esque thing when this drops, I couldn't make it though.

@Lyndomen
Copy link
Contributor

Under direction review, we're gonna take a week on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants