Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secborg Module Overhaul #2059

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Avalon-Proto
Copy link
Contributor

A total rewqwork of secborg modules

About the PR

A rework of all the items contained within the modules of the secborg, as well as the removal of the Patrol and Bastion Modules, till I figure out what to do with them

Why / Balance

The pax hypo was an extremely overpowered option, allowing secborgs to completely nullify any chance someone had of fighting back. So, I removed it, moved things around, and now I think the modules are in afar better state

Technical details

Bastion Module- Commented out, barrier moved to De-Escalation module
Patrol Module- Commented Out, seclites given to Chase, and Peacekeeper
De-Escalation- Lost Pax Hypo, gained Flashbang Launcher and Holobarrier Projector. Also a whistle
Escalation- Gained Crowd Control launcher, a hybrid Stinger/Teargas Grenade launcher, and a whistle
Peacekeeper- Gained Seclite
Chase- Gained Seclite, Whistle, Lost MEG, Gained Disabler. Bastion module may be reworked later into a proper weapon module

Media

Requirements

Breaking changes

Changelog

🆑 tweak: Secborg Modules have been redesigned, for better peacekeeping duty across NT stations!

A total rewqwork of secborg modules
@github-actions github-actions bot added Changes: YML Changes any yml files S: Merge Conflict Fix your PR! labels Oct 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Removed patrol module fully
@Avalon-Proto
Copy link
Contributor Author

Patrol Module fried, bastion remains for later repurposing

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
@Avalon-Proto
Copy link
Contributor Author

Hey Milon. Gonna help me fix the GLs anytime soon? I wanna see this in action

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the size/M 64-255 lines label Dec 25, 2024
@Avalon-Proto
Copy link
Contributor Author

Why is the commented out bastion causing a conflict I'm getting rid of it :elp:

@Avalon-Proto Avalon-Proto marked this pull request as ready for review December 25, 2024 01:16
@Avalon-Proto Avalon-Proto requested a review from a team as a code owner December 25, 2024 01:16
@MadiMadsen
Copy link

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

@Bonktrauma
Copy link
Contributor

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

@Avalon-Proto
Copy link
Contributor Author

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

@Radezolid
Copy link
Contributor

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

Pretty much you would need to do this https://github.com/DeltaV-Station/Delta-v/blob/master/Resources/Prototypes/Entities/Objects/Materials/Sheets/glass.yml#L111

@Bonktrauma
Copy link
Contributor

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

https://discord.com/channels/968983104247185448/1206353544186171482/1268113845705244813

I dont think danger wanted them to have cuffs

@Avalon-Proto
Copy link
Contributor Author

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

https://discord.com/channels/968983104247185448/1206353544186171482/1268113845705244813

I dont think danger wanted them to have cuffs

Well danger is no longer part of this project last I knew as he gave them the overpowered pax instead. So I think cuffs+ my modified modules are fine

@IamVelcroboy
Copy link
Member

something i was curious about was that there were plans to add a module for zip ties for security borgs. I'm wondering if that could be part of this overhaul or if that's out of scope of your current plans.

Secborgs won't be given any form of restraints iirc

Correction. If I knew how to I'd give them zip ties. At one point @IamVelcroboy had a working ziptie module

Pretty much you would need to do this https://github.com/DeltaV-Station/Delta-v/blob/master/Resources/Prototypes/Entities/Objects/Materials/Sheets/glass.yml#L111

If you remind me after New Years, I will dig out my prototype. But yes, iirc, that's what you need to do.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Dec 30, 2024
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants