Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ash storms to lavaland #2445

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

deltanedas
Copy link
Member

About the PR

every 5-10 minutes, an ash storm will kick up. for 1-2 minutes it will do 4 heat dps to any mob exposed to the storm (except for ashwalkers)

added ashwalker mob, theres no spawns or anything but they can tolerate the low oxygen and ash storms

Why / Balance

tg parity, creates some danger to straying too far from the base for too long
bluespace shelter capsules soon should you get trolled

it only damages living and crit mobs, so you wont get 5000 burn from dying outside

Technical details

  • for ashwalkers, added SaturationLoss to LungComponent. can be used to change how harpies breathe in the future
  • added WeatherScheduler which cycles a set of weather stages for a map
  • WeatherPrototype can now define damage which is applied if you are on a tile with weather effects

Media

based urist mcash vs cringe uristmcscales
01:33:31

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

no

Changelog
🆑

  • add: Ash storms can now happen on lavaland, run for shelter if you get caught in one!

@deltanedas deltanedas requested a review from a team December 15, 2024 01:46
@deltanedas deltanedas requested review from a team as code owners December 15, 2024 01:46
@github-actions github-actions bot added size/L 256-1023 lines S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files and removed S: Needs Review labels Dec 15, 2024
@Bonktrauma
Copy link
Contributor

Couldn't the weather scheduler be used to give glacier blizzards?

@deltanedas
Copy link
Member Author

it can but i dont like random people going down to the surface, getting stuck in a blizzard and dying. leave that for salv :trollface:

@Lyndomen
Copy link
Contributor

taking in for review, gonna test it for a day

@dvir001
Copy link
Contributor

dvir001 commented Dec 16, 2024

@deltanedas new-frontiers-14/frontier-station-14#1951
If you are adding ashwalker, you need to also add this.

@deltanedas
Copy link
Member Author

deltanedas commented Dec 17, 2024

ashwalker doesnt have a funny accent in ss13 it just speaks unathi

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction approved, no changes requested. 💯

@deltanedas deltanedas merged commit 85a29fb into DeltaV-Station:master Dec 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants