Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal dresses for heads! #2556

Merged
merged 11 commits into from
Jan 1, 2025
Merged

Conversation

HTMLSystem
Copy link
Contributor

About the PR

Added formal dresses for all the heads that have a formal suit, but not a formal dress. Those heads are the LO, HoP, and CJ. Also added inhand sprites for the HoP's formal suit and added it to the uniform printer.

Why / Balance

Because I think it's silly and dumb that there are only suits, but not dresses. Now anyone feminine can be formal as well!

Technical details

Added new folders and sprites for all dresses, added them to the loadouts, and added them to the uniform printer.

Media

image
image image image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Added formal dresses for the LO, HoP, and CJ! Find them in their dressers, lockers, loadouts, and uniform printer!
  • add: Added the HoP's formal suit to the uniform printer!

Added it ingame, into loadouts, to the uniform printer, and to the dresser
Adds the cj formal dress into existance, to the uniform printer, and to the cj locker. Also fixes the LO's inhand sprites and it's uniform printer recipe.
Added HoP's dress into existance, to the uniform printer, to the loadout, and to the HoP's locker. Also adds the HoP's formal suit to the uniform printer, adds inhand sprites for the suit, and fixes the description of all the dresses to match their suit conterparts.
Corrected the id names of the dresses because it bothered me that it didn't follow the format.
@HTMLSystem HTMLSystem requested review from a team as code owners December 29, 2024 02:29
@github-actions github-actions bot added the size/M 64-255 lines label Dec 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Merge Conflict Fix your PR! S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Dec 29, 2024
Copy link
Contributor

github-actions bot commented Dec 29, 2024

RSI Diff Bot; head commit 9f7db25 merging into f3b11eb
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/hopformal.rsi

State Old New Status
icon Modified
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Uniforms/Jumpskirt/cjformaldress.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Uniforms/Jumpskirt/hopformaldress.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Uniforms/Jumpskirt/qmformaldress.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 9f7db25

Signed-off-by: HTML/Crystal <152909599+HTMLSystem@users.noreply.github.com>
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Dec 29, 2024
@HTMLSystem
Copy link
Contributor Author

Ready to merge now !

Edited the HoP's formal outfits to have a more service-orinted disaster mentioned and fixed the licensing on the HoP's formal dress. Idk how I fucked that one up.
@HTMLSystem
Copy link
Contributor Author

Tis ready again

@HTMLSystem HTMLSystem requested a review from Lyndomen December 30, 2024 14:44
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
@HTMLSystem
Copy link
Contributor Author

Thank you for fixing all the open prs Delta that's pretty awesome :)

@deltanedas
Copy link
Member

christmas miracle

@deltanedas deltanedas merged commit 2c287b8 into DeltaV-Station:master Jan 1, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants