Feedback popups #2561
Merged
Feedback popups #2561
+386
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: YML
2 tasks
|
I have a plan |
|
To test this just get the webhook url (this tutorial shows how https://support.discord.com/hc/en-us/articles/228383668-Intro-to-Webhooks). I'd also recommend making a temporary test component that you can add to the crowbar or something so you can listen to the after interact event (forgot its name) and have the popup appear on its target. |
|
Sweet as hell, I've passed this over to our curators to see if we missed anything |
deltanedas
requested changes
Dec 31, 2024
Content.Client/DeltaV/FeedbackPopup/FeedbackPopupWindow.xaml.cs
Outdated
Show resolved
Hide resolved
Content.Client/DeltaV/FeedbackPopup/FeedbackPopupWindow.xaml.cs
Outdated
Show resolved
Hide resolved
Content.Shared/DeltaV/FeedbackOverwatch/FeedbackPopupPrototype.cs
Outdated
Show resolved
Hide resolved
Content.Shared/DeltaV/FeedbackOverwatch/FeedbackPopupPrototype.cs
Outdated
Show resolved
Hide resolved
Content.Shared/DeltaV/FeedbackOverwatch/FeedbackPopupPrototype.cs
Outdated
Show resolved
Hide resolved
Content.Shared/DeltaV/FeedbackOverwatch/SharedFeedbackOverwatchSystem.Events.cs
Outdated
Show resolved
Hide resolved
|
I also added the round ID to the message so make sure I did that correctly (I'm sure its perfect trust)! |
deltanedas
requested changes
Jan 1, 2025
Content.Shared/DeltaV/FeedbackOverwatch/FeedbackOverwatchEvents.cs
Outdated
Show resolved
Hide resolved
Content.Client/DeltaV/FeedbackPopup/FeedbackPopupWindow.xaml.cs
Outdated
Show resolved
Hide resolved
deltanedas
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Getting feedback is difficult when its just random polls on discord. It's also sometimes hard to tell if something has changed in game! This system will allow you to easily make popups to:
1.) Notify people that there is a new feature being tested
2.) Get feedback from players
Perfect world I would love to have it automatically relay events from in game responses to the discord. However, that is just too complex for me right now! Forcing people to log into discord to give feedback isn't the best :(I figured it outTechnical details
System works like this:
When you want to send a popup to a player use
SendPopupinSharedFeedbackOverwatchSystem.cs. That will send aFeedbackPopupMessageto that player. When the player gets that message, they will create a popup that they can give feedback in. When they submit, the client sends aFeedbackResponseMessage. The feedback manager is listening for this, and when it gets one it will relay it through the discord webhook!Media
2024-12-31.01-18-12.mp4
Requirements