Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add except for varkey_list loop in dfmt.preprocess_merge_meteofiles_era5() #873

Closed
veenstrajelmer opened this issue Jun 6, 2024 · 0 comments · Fixed by #889
Closed

add except for varkey_list loop in dfmt.preprocess_merge_meteofiles_era5() #873

veenstrajelmer opened this issue Jun 6, 2024 · 0 comments · Fixed by #889

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jun 6, 2024

the varkey_list loop currently does not have an else/except, so if one would supply varlist_list = [['msl','u10n','v10n','chnk','d2m','t2m','ssr','strd','mer','mtpr']], it will silently do nothing

if varkey_list == ['msl','u10n','v10n','chnk']:

Also when passing separate quantities it will fail in this case. At least add an exception.

Better approach would be to create a dictionary of abbreviations/quantities and remove the if-loop: #887

@veenstrajelmer veenstrajelmer changed the title add else for varkey_list loop in dfmt.preprocess_merge_meteofiles_era5() add except for varkey_list loop in dfmt.preprocess_merge_meteofiles_era5() Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant