You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the varkey_list loop in dfmt.preprocess_merge_meteofiles_era5() only supports a limited set of meteo combinations. This should be more flexible. Better approach would be to:
create a dictionary of abbreviations/quantities and remove the if-loop
support for separate quantities, all should now be supported by the FM kernel since DIMRset 2.26.05 (8 dec 2023), consider adding a warning if not sticking to the four predefined combinations
add backwards compatibility for combined quantities. Do notice the rainfall rate +-operand.
test_preprocess_merge_meteofiles_era5_unsupported_varlist will fail since ["msl"] will not be unsupported anymore, so restructure this testcase
the varkey_list loop in
dfmt.preprocess_merge_meteofiles_era5()
only supports a limited set of meteo combinations. This should be more flexible. Better approach would be to:+
-operand.test_preprocess_merge_meteofiles_era5_unsupported_varlist
will fail since["msl"]
will not be unsupported anymore, so restructure this testcaseOld snippet of the code:
dfm_tools/dfm_tools/modelbuilder.py
Lines 208 to 225 in f6069de
The text was updated successfully, but these errors were encountered: