Skip to content

Commit

Permalink
Use static list of invalidProps
Browse files Browse the repository at this point in the history
  • Loading branch information
DemitryT committed Jun 14, 2020
1 parent eefdc07 commit 12fa42f
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 3 deletions.
25 changes: 23 additions & 2 deletions ReactS3Uploader.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,32 @@ var ReactS3Uploader = createReactClass({
if ( this.props.autoUpload ) {
additional.onChange = this.uploadFile;
}

var temporaryProps = objectAssign({}, this.props, additional);
var inputProps = {};

var invalidProps = Object.keys(ReactS3Uploader.propTypes);
// Below line doesn't work on production, only locally. Workaround is below.
// var invalidProps = Object.keys(ReactS3Uploader.propTypes);
var invalidProps = [
"signingUrl",
"getSignedUrl",
"preprocess",
"onSignedUrl",
"onProgress",
"onFinish",
"onError",
"signingUrlMethod",
"signingUrlHeaders",
"signingUrlQueryParams",
"signingUrlWithCredentials",
"uploadRequestHeaders",
"contentDisposition",
"server",
"scrubFilename",
"s3path",
"inputRef",
"autoUpload",
]

for(var key in temporaryProps) {
if(temporaryProps.hasOwnProperty(key) && invalidProps.indexOf(key) === -1) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"aws-sdk": "2.x",
"create-react-class": "^15.5.2",
"object-assign": "^2.0.0",
"prop-types": "^15.5.8",
"prop-types": "^15.7.2",
"uuid": "^3.1.0"
}
}

0 comments on commit 12fa42f

Please sign in to comment.