Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Linkedin urls #2406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Validate Linkedin urls #2406

wants to merge 2 commits into from

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Jun 27, 2024 •
edited
Loading

This change

  • ensures that the user has submitted a LinkedIn url rather than another other domain
  • includes a management command to reformat forwarded linkedin urls

@VirginiaDooley VirginiaDooley force-pushed the hotfix/validate-linkedin branch 3 times, most recently from 463a57c to 73ddc78 Compare June 28, 2024 18:09
symroe
symroe requested changes Jul 16, 2024
View reviewed changes
ynr/apps/people/helpers.py Outdated
@@ -120,6 +121,12 @@ def clean_twitter_username(username):
return username


def clean_linkedin_url(url):
if not re.match(r"^https?://(www\.)?linkedin\.com/in/[\w-]+/?$", url):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this as per the insta PR to use urlparse to match the domain(s) and path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I had! Will do.

@VirginiaDooley VirginiaDooley requested a review from symroe July 16, 2024 14:09
@VirginiaDooley
Copy link
Contributor Author

@sym We have several linkedin urls that are redirects, for example:
http://uk.linkedin.com/pub/guto-bebb/b2/988/81b/en redirects to https://www.linkedin.com/in/guto-bebb-81b988b2/ which passes our validation requirements added in this PR. Shall I add uk.linkedin.com to the list of validated domains or do you have other ideas?

FYI, we have 5,556 instances of a LinkedIn PersonIdentifier of which 1.635 have "uk.linkedin.com" in the value.

@VirginiaDooley VirginiaDooley force-pushed the hotfix/validate-linkedin branch from c4a34fc to b9d4747 Compare July 18, 2024 14:53
@VirginiaDooley VirginiaDooley force-pushed the hotfix/validate-linkedin branch from b9d4747 to 5ea0157 Compare July 18, 2024 14:54
@VirginiaDooley VirginiaDooley requested a review from symroe July 18, 2024 14:56
@VirginiaDooley VirginiaDooley force-pushed the hotfix/validate-linkedin branch from 9c60a28 to 5ea0157 Compare July 18, 2024 15:15
@symroe symroe mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symroe symroe Awaiting requested review from symroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirginiaDooley @symroe